diff mbox

[U-Boot] ARM: OMAP5: Set fdt_high to enable booting with Device tree

Message ID 1363848917-1106-1-git-send-email-r.sricharan@ti.com
State Changes Requested
Delegated to: Tom Rini
Headers show

Commit Message

SRICHARAN R March 21, 2013, 6:55 a.m. UTC
While booting with dtblob, if fdt_high is not set to
0xffffffff, the dt blob is relocated to a higher address,
which the kernel is not able to use without HIGHMEM.

So set it to 0xffffffff to avoid the issue.

Signed-off-by: Sricharan R <r.sricharan@ti.com>
---
 include/configs/omap5_common.h |    1 +
 1 file changed, 1 insertion(+)

Comments

Tom Rini March 21, 2013, 11:59 a.m. UTC | #1
On Thu, Mar 21, 2013 at 12:25:17PM +0530, Sricharan R wrote:

> While booting with dtblob, if fdt_high is not set to
> 0xffffffff, the dt blob is relocated to a higher address,
> which the kernel is not able to use without HIGHMEM.
> 
> So set it to 0xffffffff to avoid the issue.
> 
> Signed-off-by: Sricharan R <r.sricharan@ti.com>

That's fine, but while we're making this DT-happy, lets add fdtaddr to
the env (so there's a good default and safe address to load the DT to)
and make the default boot commands load and pass the DT.  That means
that we need to make sure that you probably need to enable
CONFIG_ENV_VARS_UBOOT_CONFIG and perhaps
CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG (and see board/ti/am335x/board.c
for an example) so that we pick out the right DT file to load.
SRICHARAN R March 22, 2013, 1:01 p.m. UTC | #2
Hi Tom,
On Thursday 21 March 2013 05:29 PM, Tom Rini wrote:
> On Thu, Mar 21, 2013 at 12:25:17PM +0530, Sricharan R wrote:
> 
>> While booting with dtblob, if fdt_high is not set to
>> 0xffffffff, the dt blob is relocated to a higher address,
>> which the kernel is not able to use without HIGHMEM.
>>
>> So set it to 0xffffffff to avoid the issue.
>>
>> Signed-off-by: Sricharan R <r.sricharan@ti.com>
> 
> That's fine, but while we're making this DT-happy, lets add fdtaddr to
> the env (so there's a good default and safe address to load the DT to)
> and make the default boot commands load and pass the DT.  That means
> that we need to make sure that you probably need to enable
> CONFIG_ENV_VARS_UBOOT_CONFIG and perhaps
> CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG (and see board/ti/am335x/board.c
> for an example) so that we pick out the right DT file to load.
> 
Thanks for the inputs. So i will have to check if we have eeprom as
in your case for runtime configuration.Even otherwise the default
should be changed as you said. Plus will also change default as zImage.
will post shortly.

Regards,
 Sricharan
diff mbox

Patch

diff --git a/include/configs/omap5_common.h b/include/configs/omap5_common.h
index af97564..f0416df 100644
--- a/include/configs/omap5_common.h
+++ b/include/configs/omap5_common.h
@@ -143,6 +143,7 @@ 
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"loadaddr=0x82000000\0" \
 	"console=ttyO2,115200n8\0" \
+	"fdt_high=0xffffffff\0" \
 	"usbtty=cdc_acm\0" \
 	"vram=16M\0" \
 	"mmcdev=0\0" \