diff mbox

libv4l: depends on jpeg so must select it

Message ID 1363123025-8481-1-git-send-email-arnout@mind.be
State Accepted
Commit 196c716bc61582f1ccf03dc834cbb929c553e9aa
Headers show

Commit Message

Arnout Vandecappelle March 12, 2013, 9:17 p.m. UTC 
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>

Fixes http://autobuild.buildroot.net/results/3053854fccd65bc5b28384f2a2039a33abeeea47

The introduction of the error message for the jpeg virtual package exposes
this kind of error.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
Perhaps it would be nice to add this type of check to the generic package
infrastructure: if a package is built, it should always be selected. Of
course, that makes it impossible to do a quick build of a package without
reconfiguring, but we can add another make variable that bypasses the check.
---
 package/libv4l/Config.in |    1 +
 1 file changed, 1 insertion(+)

Comments

Peter Korsgaard March 12, 2013, 9:32 p.m. UTC | #1 
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 Arnout> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
 Arnout> Fixes http://autobuild.buildroot.net/results/3053854fccd65bc5b28384f2a2039a33abeeea47

 Arnout> The introduction of the error message for the jpeg virtual
 Arnout> package exposes this kind of error.

Committed, thanks.

 Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 Arnout> ---

 Arnout> Perhaps it would be nice to add this type of check to the
 Arnout> generic package infrastructure: if a package is built, it
 Arnout> should always be selected. Of course, that makes it impossible
 Arnout> to do a quick build of a package without reconfiguring, but we
 Arnout> can add another make variable that bypasses the check.

Yes, sounds like a nice feature. Care to cook up a patch for that?
diff mbox

Patch

diff --git a/package/libv4l/Config.in b/package/libv4l/Config.in
index 1e5eec6..cb0f43c 100644
--- a/package/libv4l/Config.in
+++ b/package/libv4l/Config.in
@@ -1,6 +1,7 @@ 
 config BR2_PACKAGE_LIBV4L
 	bool "libv4l"
 	depends on BR2_LARGEFILE
+	select BR2_PACKAGE_JPEG
 	help
 	  libv4l is an accompanying collection of libraries that adds a thin
 	  abstraction layer on top of video4linux2 (V4L2) devices.