Patchwork [U-Boot,v6,28/31] serial: ns16550: Remove unwanted cast

login
register
mail settings
Submitter Simon Glass
Date March 6, 2013, 12:40 a.m.
Message ID <1362530405-10824-29-git-send-email-sjg@chromium.org>
Download mbox | patch
Permalink /patch/225234/
State Accepted, archived
Delegated to: Tom Rini
Headers show

Comments

Simon Glass - March 6, 2013, 12:40 a.m.
This cast does not seem correct, since we should be writing to a pointer,
not a ulong.

This fixes the following warning on nds32:

-ns16550.c:49: warning: passing argument 2 of 'writeb' makes pointer from integer without a cast

Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v6:
- Add new patch to fix up ns16550 cast

Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None

 drivers/serial/ns16550.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index 87a0917..b2da8b3 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -46,7 +46,7 @@  void NS16550_init(NS16550_t com_port, int baud_divisor)
 					defined(CONFIG_AM33XX)
 	serial_out(0x7, &com_port->mdr1);	/* mode select reset TL16C750*/
 #endif
-	serial_out(UART_LCR_BKSE | UART_LCRVAL, (ulong)&com_port->lcr);
+	serial_out(UART_LCR_BKSE | UART_LCRVAL, &com_port->lcr);
 	serial_out(0, &com_port->dll);
 	serial_out(0, &com_port->dlm);
 	serial_out(UART_LCRVAL, &com_port->lcr);