| Message ID | 3521df0e-25e0-4c6f-baaf-7397e08a0925@TX2EHSMHS042.ehs.local |
|---|---|
| State | Superseded |
| Headers | show |
Hi Jagannadha, On Thu, Feb 28, 2013 at 6:33 AM, Jagannadha Sutradharudu Teki <jagannadha.sutradharudu-teki@xilinx.com> wrote: > This patch provides a support to build the user specified dts. > If the user is not specifying any dts, then it should build the > dts from CONFIG_DEFAULT_DEVICE_TREE. > > $ make -> choose the default dts, defined as CONFIG_DEFAULT_DEVICE_TREE > $ make DEVICE_TREE=<dts-file-name> -> choose the specified dts from the user > > Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com> This is a useful patch thank you. > --- > dts/Makefile | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dts/Makefile b/dts/Makefile > index 922c78c..dd6c1fa 100644 > --- a/dts/Makefile > +++ b/dts/Makefile > @@ -29,7 +29,9 @@ LIB = $(obj)libdts.o > > $(if $(CONFIG_DEFAULT_DEVICE_TREE),,\ > $(error Please define CONFIG_DEFAULT_DEVICE_TREE in your board header file)) > +ifneq ($(DEVICE_TREE),y) > DEVICE_TREE = $(subst ",,$(CONFIG_DEFAULT_DEVICE_TREE)) > +endif It would be better if we could not give an error if DEVICE_TREE is defined, even if there is no CONFIG_DEFAULT_DEVICE_TREE. > > $(if $(CONFIG_ARCH_DEVICE_TREE),,\ > $(error Your architecture does not have device tree support enabled. \ > -- > 1.7.4 > > Regards, Simon
Hi Simon, > -----Original Message----- > From: sjg@google.com [mailto:sjg@google.com] On Behalf Of Simon Glass > Sent: 28 February 2013 20:08 > To: Jagannadha Sutradharudu Teki > Cc: u-boot@lists.denx.de; Jerry Van Baren; monstr@monstr.eu; Jagannadha > Sutradharudu Teki; Vadim Bendebury > Subject: Re: [PATCH] dts/Makefile: Build the user specified dts > > Hi Jagannadha, > > On Thu, Feb 28, 2013 at 6:33 AM, Jagannadha Sutradharudu Teki > <jagannadha.sutradharudu-teki@xilinx.com> wrote: > > This patch provides a support to build the user specified dts. > > If the user is not specifying any dts, then it should build the dts > > from CONFIG_DEFAULT_DEVICE_TREE. > > > > $ make -> choose the default dts, defined as > > CONFIG_DEFAULT_DEVICE_TREE $ make DEVICE_TREE=<dts-file-name> -> > > choose the specified dts from the user > > > > Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com> > > This is a useful patch thank you. > > > --- > > dts/Makefile | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/dts/Makefile b/dts/Makefile index 922c78c..dd6c1fa 100644 > > --- a/dts/Makefile > > +++ b/dts/Makefile > > @@ -29,7 +29,9 @@ LIB = $(obj)libdts.o > > > > $(if $(CONFIG_DEFAULT_DEVICE_TREE),,\ $(error Please define > > CONFIG_DEFAULT_DEVICE_TREE in your board header file)) > > +ifneq ($(DEVICE_TREE),y) > > DEVICE_TREE = $(subst ",,$(CONFIG_DEFAULT_DEVICE_TREE)) > > +endif > > It would be better if we could not give an error if DEVICE_TREE is defined, > even if there is no CONFIG_DEFAULT_DEVICE_TREE. For backward compatibility, as most of the users are defined CONFIG_DEFAULT_DEVICE_TREE on their board configs ie the reason I have proceeded this way. May be I will send the v2 as you suggested., is that fine? Please comment. Thanks, Jagan. > > > > > $(if $(CONFIG_ARCH_DEVICE_TREE),,\ > > $(error Your architecture does not have device tree support enabled. > > \ > > -- > > 1.7.4 > > > > > > Regards, > Simon This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
diff --git a/dts/Makefile b/dts/Makefile index 922c78c..dd6c1fa 100644 --- a/dts/Makefile +++ b/dts/Makefile @@ -29,7 +29,9 @@ LIB = $(obj)libdts.o $(if $(CONFIG_DEFAULT_DEVICE_TREE),,\ $(error Please define CONFIG_DEFAULT_DEVICE_TREE in your board header file)) +ifneq ($(DEVICE_TREE),y) DEVICE_TREE = $(subst ",,$(CONFIG_DEFAULT_DEVICE_TREE)) +endif $(if $(CONFIG_ARCH_DEVICE_TREE),,\ $(error Your architecture does not have device tree support enabled. \
This patch provides a support to build the user specified dts. If the user is not specifying any dts, then it should build the dts from CONFIG_DEFAULT_DEVICE_TREE. $ make -> choose the default dts, defined as CONFIG_DEFAULT_DEVICE_TREE $ make DEVICE_TREE=<dts-file-name> -> choose the specified dts from the user Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com> --- dts/Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)