Patchwork Docu: Add LIBFOO_EXTRACT_CMDS

login
register
mail settings
Submitter Stephan Hoffmann
Date Jan. 29, 2013, 10:04 a.m.
Message ID <1359453890-23460-1-git-send-email-sho@relinux.de>
Download mbox | patch
Permalink /patch/216485/
State Superseded
Headers show

Comments

Stephan Hoffmann - Jan. 29, 2013, 10:04 a.m.
Signed-off-by: Stephan Hoffmann <sho@relinux.de>
---
 docs/manual/adding-packages-generic.txt |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Samuel Martin - Jan. 29, 2013, 10:18 a.m.
Hi Stephan,

2013/1/29 Stephan Hoffmann <sho@relinux.de>:
> Signed-off-by: Stephan Hoffmann <sho@relinux.de>
> ---
>  docs/manual/adding-packages-generic.txt |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/docs/manual/adding-packages-generic.txt b/docs/manual/adding-packages-generic.txt
> index 7b8561a..53c8c21 100644
> --- a/docs/manual/adding-packages-generic.txt
> +++ b/docs/manual/adding-packages-generic.txt
> @@ -288,6 +288,9 @@ LIBFOO_VERSION = 2.32
>  Now, the variables that define what should be performed at the
>  different steps of the build process.
>
> +* +LIBFOO_EXTRACT_CMDS+ lists the actions to be performed to
> +  extract the package in case no standard method applies
It could be nice to add what are the standard/supported methods

> +
>  * +LIBFOO_CONFIGURE_CMDS+ lists the actions to be performed to
>    configure the package before its compilation.
>
> --
> 1.7.0.4
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot


Regards,
Stephan Hoffmann - Jan. 29, 2013, 10:39 a.m.
Am 29.01.2013 11:18, schrieb Samuel Martin:
> Hi Stephan,
>
> 2013/1/29 Stephan Hoffmann <sho@relinux.de>:
>> Signed-off-by: Stephan Hoffmann <sho@relinux.de>
>> ---
>>  docs/manual/adding-packages-generic.txt |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/docs/manual/adding-packages-generic.txt b/docs/manual/adding-packages-generic.txt
>> index 7b8561a..53c8c21 100644
>> --- a/docs/manual/adding-packages-generic.txt
>> +++ b/docs/manual/adding-packages-generic.txt
>> @@ -288,6 +288,9 @@ LIBFOO_VERSION = 2.32
>>  Now, the variables that define what should be performed at the
>>  different steps of the build process.
>>
>> +* +LIBFOO_EXTRACT_CMDS+ lists the actions to be performed to
>> +  extract the package in case no standard method applies
> It could be nice to add what are the standard/supported methods
Sure. But I do not know them, I just decided to document this one
because I had to search for the information recently.

>
>> +
>>  * +LIBFOO_CONFIGURE_CMDS+ lists the actions to be performed to
>>    configure the package before its compilation.
>>
>> --
>> 1.7.0.4
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
> Regards,
>
Arnout Vandecappelle - Jan. 29, 2013, 5:29 p.m.
On 29/01/13 11:39, Stephan Hoffmann wrote:
> Am 29.01.2013 11:18, schrieb Samuel Martin:
[snip]
>>> >>+* +LIBFOO_EXTRACT_CMDS+ lists the actions to be performed to
>>> >>+  extract the package in case no standard method applies
>> >It could be nice to add what are the standard/supported methods
> Sure. But I do not know them, I just decided to document this one
> because I had to search for the information recently.

  There is currently only one: tar - and if you don't override the 
commands, tar is used regardless of filetype or extension.

  It supports three compression types: gzip (extension .gz or .tgz), 
bzip2 (extension .bz2, .tbz or .tbz2), and xz (extension .xz).

  Feel free to copy the above directly :-)

  Regards,
  Arnout
Stephan Hoffmann - Feb. 16, 2013, 4:22 p.m.
Am 29.01.2013 18:29, schrieb Arnout Vandecappelle:
> On 29/01/13 11:39, Stephan Hoffmann wrote:
>> Am 29.01.2013 11:18, schrieb Samuel Martin:
> [snip]
>>>> >>+* +LIBFOO_EXTRACT_CMDS+ lists the actions to be performed to
>>>> >>+  extract the package in case no standard method applies
>>> >It could be nice to add what are the standard/supported methods
>> Sure. But I do not know them, I just decided to document this one
>> because I had to search for the information recently.
>
>  There is currently only one: tar - and if you don't override the
> commands, tar is used regardless of filetype or extension.
>
>  It supports three compression types: gzip (extension .gz or .tgz),
> bzip2 (extension .bz2, .tbz or .tbz2), and xz (extension .xz).
>
>  Feel free to copy the above directly :-)
>
I do not think that the list of XXX_CMDS variables is the right place to
document the default behavior without them.

Of course whe should have a documentation of the default behaior
somewhere in the manual, but I am not enough familiar with this topic to
write it.

So I suggest to commit my patch as it is, it still applies to HEAD.

Regards

Stephan
>  Regards,
>  Arnout
>
>
Arnout Vandecappelle - Feb. 16, 2013, 5:35 p.m.
On 16/02/13 17:22, Stephan Hoffmann wrote:
> Am 29.01.2013 18:29, schrieb Arnout Vandecappelle:
>> On 29/01/13 11:39, Stephan Hoffmann wrote:
>>> Am 29.01.2013 11:18, schrieb Samuel Martin:
>> [snip]
>>>>>>> +* +LIBFOO_EXTRACT_CMDS+ lists the actions to be performed to
>>>>>>> +  extract the package in case no standard method applies
>>>>> It could be nice to add what are the standard/supported methods
>>> Sure. But I do not know them, I just decided to document this one
>>> because I had to search for the information recently.
>>
>>   There is currently only one: tar - and if you don't override the
>> commands, tar is used regardless of filetype or extension.
>>
>>   It supports three compression types: gzip (extension .gz or .tgz),
>> bzip2 (extension .bz2, .tbz or .tbz2), and xz (extension .xz).
>>
>>   Feel free to copy the above directly :-)
>>
> I do not think that the list of XXX_CMDS variables is the right place to
> document the default behavior without them.
>
> Of course whe should have a documentation of the default behaior
> somewhere in the manual, but I am not enough familiar with this topic to
> write it.
>
> So I suggest to commit my patch as it is, it still applies to HEAD.

  Good point.

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Patch

diff --git a/docs/manual/adding-packages-generic.txt b/docs/manual/adding-packages-generic.txt
index 7b8561a..53c8c21 100644
--- a/docs/manual/adding-packages-generic.txt
+++ b/docs/manual/adding-packages-generic.txt
@@ -288,6 +288,9 @@  LIBFOO_VERSION = 2.32
 Now, the variables that define what should be performed at the
 different steps of the build process.
 
+* +LIBFOO_EXTRACT_CMDS+ lists the actions to be performed to
+  extract the package in case no standard method applies
+
 * +LIBFOO_CONFIGURE_CMDS+ lists the actions to be performed to
   configure the package before its compilation.