Patchwork [3.5.y.z,extended,stable] Patch "mac80211: use del_timer_sync for final sta cleanup timer" has been added to staging queue

mail settings
Submitter Herton Ronaldo Krzesinski
Date Jan. 23, 2013, 4:40 a.m.
Message ID <>
Download mbox | patch
Permalink /patch/214727/
State New
Headers show


Herton Ronaldo Krzesinski - Jan. 23, 2013, 4:40 a.m.
This is a note to let you know that I have just added a patch titled

    mac80211: use del_timer_sync for final sta cleanup timer

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see



From d3f34f769a24c4e627849deb774461dcc239c12d Mon Sep 17 00:00:00 2001
From: Johannes Berg <>
Date: Thu, 13 Dec 2012 23:08:52 +0100
Subject: [PATCH] mac80211: use del_timer_sync for final sta cleanup timer

commit a56f992cdabc63f56b4b142885deebebf936ff76 upstream.

This is a very old bug, but there's nothing that prevents the
timer from running while the module is being removed when we
only do del_timer() instead of del_timer_sync().

The timer should normally not be running at this point, but
it's not clearly impossible (or we could just remove this.)

Tested-by: Ben Greear <>
Signed-off-by: Johannes Berg <>
Signed-off-by: Herton Ronaldo Krzesinski <>
 net/mac80211/sta_info.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
index 6c74f1e..fec8eab 100644
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -844,7 +844,7 @@  void sta_info_init(struct ieee80211_local *local)

 void sta_info_stop(struct ieee80211_local *local)
-	del_timer(&local->sta_cleanup);
+	del_timer_sync(&local->sta_cleanup);
 	sta_info_flush(local, NULL);