Patchwork [1/6] hw/arm_sysctl.c: Add missing 'break' statements

login
register
mail settings
Submitter Peter Maydell
Date Jan. 21, 2013, 12:50 p.m.
Message ID <1358772656-7406-2-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/214143/
State New
Headers show

Comments

Peter Maydell - Jan. 21, 2013, 12:50 p.m.
Add some break statements that were accidentally omitted
from some cases of arm_sysctl_write(). The omission was
harmless because in both cases the following case did
an immediate break, but adding the breaks explicitly
placates static analysers and avoids weird behaviour if
the following register is ever implemented as something
other than a no-op.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/arm_sysctl.c |    2 ++
 1 file changed, 2 insertions(+)

Patch

diff --git a/hw/arm_sysctl.c b/hw/arm_sysctl.c
index a196fcc..6d99f9c 100644
--- a/hw/arm_sysctl.c
+++ b/hw/arm_sysctl.c
@@ -199,6 +199,7 @@  static void arm_sysctl_write(void *opaque, hwaddr offset,
     switch (offset) {
     case 0x08: /* LED */
         s->leds = val;
+        break;
     case 0x0c: /* OSC0 */
     case 0x10: /* OSC1 */
     case 0x14: /* OSC2 */
@@ -295,6 +296,7 @@  static void arm_sysctl_write(void *opaque, hwaddr offset,
             /* On VExpress this register is unimplemented and will RAZ/WI */
             break;
         }
+        break;
     case 0x54: /* CLCDSER */
     case 0x64: /* DMAPSR0 */
     case 0x68: /* DMAPSR1 */