Patchwork [2/2] ppc/iommu: use find_first_bit to look up entries in the iommu table

login
register
mail settings
Submitter Thadeu Lima de Souza Cascardo
Date Dec. 28, 2012, 7:08 p.m.
Message ID <1356721732-24556-2-git-send-email-cascardo@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/208522/
State Not Applicable
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Thadeu Lima de Souza Cascardo - Dec. 28, 2012, 7:08 p.m.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
---
 arch/powerpc/kernel/iommu.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

Patch

diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c
index 6d48ff8..91e2b99 100644
--- a/arch/powerpc/kernel/iommu.c
+++ b/arch/powerpc/kernel/iommu.c
@@ -725,14 +725,9 @@  void iommu_free_table(struct iommu_table *tbl, const char *node_name)
 		clear_bit(0, tbl->it_map);
 
 	/* verify that table contains no entries */
-	/* it_size is in entries, and we're examining 64 at a time */
-	for (i = 0; i < (tbl->it_size/64); i++) {
-		if (tbl->it_map[i] != 0) {
+	if (find_first_bit(tbl->it_map, tbl->it_size) < tbl->it_size)
 			printk(KERN_WARNING "%s: Unexpected TCEs for %s\n",
 				__func__, node_name);
-			break;
-		}
-	}
 
 	/* calculate bitmap size in bytes */
 	bitmap_sz = (tbl->it_size + 7) / 8;