Patchwork [U-Boot,4/4] patman: Add settings to the list of modules to doctest

login
register
mail settings
Submitter Doug Anderson
Date Dec. 1, 2012, 12:29 a.m.
Message ID <1354321745-1359-4-git-send-email-dianders@chromium.org>
Download mbox | patch
Permalink /patch/203092/
State Superseded, archived
Delegated to: Tom Rini
Headers show

Comments

Doug Anderson - Dec. 1, 2012, 12:29 a.m.
The settings modules now has doctests, so run them.

Signed-off-by: Doug Anderson <dianders@chromium.org>
---
 tools/patman/patman.py |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
Simon Glass - Dec. 3, 2012, 11:04 p.m.
On Fri, Nov 30, 2012 at 4:29 PM, Doug Anderson <dianders@chromium.org> wrote:
> The settings modules now has doctests, so run them.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>

Acked-by: Simon Glass <sjg@chromium.org>

> ---
>  tools/patman/patman.py |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/patman/patman.py b/tools/patman/patman.py
> index 54a252e..6825de4 100755
> --- a/tools/patman/patman.py
> +++ b/tools/patman/patman.py
> @@ -85,8 +85,9 @@ if options.test:
>      result = unittest.TestResult()
>      suite.run(result)
>
> -    suite = doctest.DocTestSuite('gitutil')
> -    suite.run(result)
> +    for module in ['gitutil', 'settings']:
> +        suite = doctest.DocTestSuite(module)
> +        suite.run(result)
>
>      # TODO: Surely we can just 'print' result?
>      print result
> --
> 1.7.7.3
>

Patch

diff --git a/tools/patman/patman.py b/tools/patman/patman.py
index 54a252e..6825de4 100755
--- a/tools/patman/patman.py
+++ b/tools/patman/patman.py
@@ -85,8 +85,9 @@  if options.test:
     result = unittest.TestResult()
     suite.run(result)
 
-    suite = doctest.DocTestSuite('gitutil')
-    suite.run(result)
+    for module in ['gitutil', 'settings']:
+        suite = doctest.DocTestSuite(module)
+        suite.run(result)
 
     # TODO: Surely we can just 'print' result?
     print result