Patchwork [020/270] nfsd4: fix nfs4 stateid leak

mail settings
Submitter Herton Ronaldo Krzesinski
Date Nov. 26, 2012, 4:55 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/201753/
State New
Headers show


Herton Ronaldo Krzesinski - Nov. 26, 2012, 4:55 p.m.
3.5.7u1 -stable review patch.  If anyone has any objections, please let me know.


From: "J. Bruce Fields" <>

commit cf9182e90b2af04245ac4fae497fe73fc71285b4 upstream.

Processes that open and close multiple files may end up setting this
oo_last_closed_stid without freeing what was previously pointed to.
This can result in a major leak, visible for example by watching the
nfsd4_stateids line of /proc/slabinfo.

Reported-by: Cyril B. <>
Tested-by: Cyril B. <>
Signed-off-by: J. Bruce Fields <>
Signed-off-by: Herton Ronaldo Krzesinski <>
 fs/nfsd/nfs4state.c |    1 +
 1 file changed, 1 insertion(+)


diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index e8ead04..be324aa 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -3748,6 +3748,7 @@  nfsd4_close(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
 	memcpy(&close->cl_stateid, &stp->st_stid.sc_stateid, sizeof(stateid_t));
+	release_last_closed_stateid(oo);
 	oo->oo_last_closed_stid = stp;
 	/* place unused nfs4_stateowners on so_close_lru list to be