[3.5.yuz,extended,stable] Patch "ALSA: hda - Always check array bounds in" has been added to staging queue

Submitted by Herton Ronaldo Krzesinski on Nov. 21, 2012, 5:09 a.m.


Message ID 1353474541-8805-1-git-send-email-herton.krzesinski@canonical.com
State New
Headers show

Commit Message

Herton Ronaldo Krzesinski Nov. 21, 2012, 5:09 a.m.
This is a note to let you know that I have just added a patch titled

    ALSA: hda - Always check array bounds in

to the linux-3.5.y-queue branch of the 3.5.yuz extended stable tree 
which can be found at:


If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.yuz tree, see



From f4e17d92b3c0f6924c2eb2d6f6c465c2e0665669 Mon Sep 17 00:00:00 2001
From: David Henningsson <david.henningsson@canonical.com>
Date: Wed, 17 Oct 2012 12:43:44 +0200
Subject: [PATCH] ALSA: hda - Always check array bounds in

commit 71aa5ebe36a4e936eff281b375a4707b6a8320f2 upstream.

Even when CONFIG_SND_DEBUG is not enabled, we don't want to
return an arbitrary memory location when the channel count is
larger than we expected.

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
 sound/pci/hda/patch_realtek.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


Patch hide | download patch | download mbox

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f6784d7..2549f0b 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -2486,8 +2486,10 @@  static const char *alc_get_line_out_pfx(struct alc_spec *spec, int ch,
 			return "PCM";
-	if (snd_BUG_ON(ch >= ARRAY_SIZE(channel_name)))
+	if (ch >= ARRAY_SIZE(channel_name)) {
+		snd_BUG();
 		return "PCM";
+	}

 	return channel_name[ch];