| Message ID | CA+m5__+d8WbPe0wtZVw4VFV5L2qbLvD-TLzXP3FmXgdukT8vAg@mail.gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Albert ARIBAUD |
| Headers | show |
Hi Tom, On Fri, 16 Nov 2012 10:14:46 -0700, Tom Warren <twarren.nvidia@gmail.com> wrote: > Albert, > > Please pull u-boot-tegra/master into ARM/master. Thanks! > > ./MAKEALL -a arm completes w/o any new errors. > checkpatch is clean, also. I see three boards failing which do build on current u-boot-arm/master: palmld palmtc zipitz2 All have the same error: /home/albert/src/u-boot-arm/common/lcd.c:125: undefined reference to `flush_dcache_range' git bisect run ./MAKEALL zipitz2 traces the problem to commit 9c9e9b0d... "lcd: Add support for flushing LCD fb from dcache after update" from Simon Glass (already Cc:). Simon, can you look into this? Tom, can you provide a fixed pull request once the issue is fixed? Amicalement,
Albert, A fix was found and posted awhile back by Simon (195662 on PatchWork - it's assigned to you as delegate). Marek's last comment was 'Just apply this', so I suppose that's his version of an Acked-by. I don't carry that fix in my tree since it's not specifically Tegra-related. I can add it and resend a pull request, or you can apply it to ARM/master and I can rebase on that (though I don't think that'll change my pull request much, if at all). Let me know, Tom On Fri, Nov 16, 2012 at 2:27 PM, Albert ARIBAUD <albert.u.boot@aribaud.net> wrote: > Hi Tom, > > On Fri, 16 Nov 2012 10:14:46 -0700, Tom Warren > <twarren.nvidia@gmail.com> wrote: > >> Albert, >> >> Please pull u-boot-tegra/master into ARM/master. Thanks! >> >> ./MAKEALL -a arm completes w/o any new errors. >> checkpatch is clean, also. > > I see three boards failing which do build on current u-boot-arm/master: > > palmld palmtc zipitz2 > > All have the same error: > > /home/albert/src/u-boot-arm/common/lcd.c:125: undefined > reference to `flush_dcache_range' > > git bisect run ./MAKEALL zipitz2 traces the problem to commit > 9c9e9b0d... "lcd: Add support for flushing LCD fb from dcache after > update" from Simon Glass (already Cc:). > > Simon, can you look into this? > > Tom, can you provide a fixed pull request once the issue is fixed? > > Amicalement, > -- > Albert.
Hi Tom, On Fri, 16 Nov 2012 14:45:49 -0700, Tom Warren <twarren.nvidia@gmail.com> wrote: > Albert, > > A fix was found and posted awhile back by Simon (195662 on PatchWork - > it's assigned to you as delegate). Marek's last comment was 'Just > apply this', so I suppose that's his version of an Acked-by. I don't > carry that fix in my tree since it's not specifically Tegra-related. > I can add it and resend a pull request, or you can apply it to > ARM/master and I can rebase on that (though I don't think that'll > change my pull request much, if at all). > > Let me know, Ideally, I would like the tegra master branch to be reworked with the fix applied so that no commit fails building. > Tom Amicalement,
Albert, Please pull u-boot-tegra/master into ARM/master. Thanks! ./MAKEALL -a arm completes w/o any new errors. checkpatch is clean, also. The following changes since commit 7a5337732e3e05b2b0de1b592fa031b2c7b4f632: Rajeshwari Shinde (1): EXYNOS5: Enable SPI booting. are available in the git repository at: git://git.denx.de/u-boot-tegra master Allen Martin (1): tegra: add CONSOLE_MUX support to tegra-kbc Mayuresh Kulkarni (1): tegra: Enable display/lcd support on Seaboard Simon Glass (16): tegra: Use const for pinmux_config_pingroup/table() tegra: Add display support to funcmux tegra: fdt: Add pwm binding and node tegra: fdt: Add LCD definitions for Tegra tegra: Add support for PWM tegra: Add LCD driver tegra: Add LCD support to Nvidia boards arm: Add control over cachability of memory regions lcd: Add CONFIG_LCD_ALIGNMENT to select frame buffer alignment lcd: Add support for flushing LCD fb from dcache after update tegra: Align LCD frame buffer to section boundary tegra: Support control of cache settings for LCD tegra: fdt: Add LCD definitions for Seaboard lcd: Add CONFIG_CONSOLE_SCROLL_LINES option to speed console tegra: Remove unnecessary CONFIG_SYS_NAND_BASE tegra: config: seaboard: Move tegra-common-post to correct place Stephen Warren (4): ARM: tegra: TrimSlice: add support for USB1 port mmc: tegra: support 4-bit operation too on 8-bit slots ARM: tegra: enable 8-bit SD slots in board files tegra: use generic fs commands in BOOTCOMMAND Wei Ni (1): tegra: Add SOC support for display/lcd README | 16 + arch/arm/cpu/armv7/cache_v7.c | 11 + arch/arm/cpu/armv7/tegra20/Makefile | 2 + arch/arm/cpu/armv7/tegra20/display.c | 409 ++++++++++++++++++ arch/arm/cpu/armv7/tegra20/pwm.c | 101 +++++ arch/arm/cpu/tegra20-common/funcmux.c | 37 ++ arch/arm/cpu/tegra20-common/pinmux.c | 4 +- arch/arm/dts/tegra20.dtsi | 105 +++++ arch/arm/include/asm/arch-tegra20/dc.h | 545 ++++++++++++++++++++++++ arch/arm/include/asm/arch-tegra20/display.h | 152 +++++++ arch/arm/include/asm/arch-tegra20/pinmux.h | 4 +- arch/arm/include/asm/arch-tegra20/pwm.h | 75 ++++ arch/arm/include/asm/system.h | 31 ++ arch/arm/lib/cache-cp15.c | 51 ++- board/compal/paz00/paz00.c | 5 +- board/compulab/dts/tegra20-trimslice.dts | 3 +- board/compulab/trimslice/trimslice.c | 8 + board/nvidia/common/board.c | 24 + board/nvidia/dts/tegra20-seaboard.dts | 33 ++ board/nvidia/harmony/harmony.c | 5 +- board/nvidia/seaboard/seaboard.c | 5 +- common/lcd.c | 89 ++++- common/main.c | 12 +- doc/device-tree-bindings/pwm/tegra20-pwm.txt | 18 + doc/device-tree-bindings/video/displaymode.txt | 42 ++ doc/device-tree-bindings/video/tegra20-dc.txt | 85 ++++ drivers/input/tegra-kbc.c | 18 +- drivers/mmc/tegra_mmc.c | 7 +- drivers/video/Makefile | 1 + drivers/video/tegra.c | 379 ++++++++++++++++ include/configs/harmony.h | 4 +- include/configs/paz00.h | 3 + include/configs/seaboard.h | 20 +- include/configs/tec.h | 1 - include/configs/tegra-common-post.h | 39 +- include/configs/tegra20-common.h | 3 + include/configs/trimslice.h | 4 + include/configs/ventana.h | 3 + include/configs/whistler.h | 3 + include/fdtdec.h | 2 + include/lcd.h | 11 + lib/fdtdec.c | 2 + 42 files changed, 2294 insertions(+), 78 deletions(-) create mode 100644 arch/arm/cpu/armv7/tegra20/display.c create mode 100644 arch/arm/cpu/armv7/tegra20/pwm.c create mode 100644 arch/arm/include/asm/arch-tegra20/dc.h create mode 100644 arch/arm/include/asm/arch-tegra20/display.h create mode 100644 arch/arm/include/asm/arch-tegra20/pwm.h create mode 100644 doc/device-tree-bindings/pwm/tegra20-pwm.txt create mode 100644 doc/device-tree-bindings/video/displaymode.txt create mode 100644 doc/device-tree-bindings/video/tegra20-dc.txt create mode 100644 drivers/video/tegra.c