Patchwork [U-Boot] include/linux/byteorder: Always defines __fswab64, __swab64p and __swab64s

login
register
mail settings
Submitter Nobuhiro Iwamatsu
Date Nov. 15, 2012, 7:33 a.m.
Message ID <1352964809-17963-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
Download mbox | patch
Permalink /patch/199201/
State Superseded
Delegated to: Marek Vasut
Headers show

Comments

Nobuhiro Iwamatsu - Nov. 15, 2012, 7:33 a.m.
From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu@renesas.com>

When __BYTEORDER_HAS_U64__ is not defined, we got warning following:

-----
/tmp/include/linux/byteorder/little_endian.h: In function ā€˜__cpu_to_be64pā€™:
/tmp/include/linux/byteorder/little_endian.h:71:2: warning: implicit declaration of function ā€˜__swab64pā€™
		[-Wimplicit-function-declaration]
-----

Usually, __arch__swab64* required for __fswab64,  __swab64p and __swab64s
is defined.  Therefore, __BYTEORDER_HAS_U64__ is unnecessary.
This removes __BYTEORDER_HAS_U64__.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu@renesas.com>
CC: Kim Phillips <kim.phillips@freescale.com>
---
 include/linux/byteorder/swab.h |    2 --
 1 file changed, 2 deletions(-)

Patch

diff --git a/include/linux/byteorder/swab.h b/include/linux/byteorder/swab.h
index bb4a046..4334fa7 100644
--- a/include/linux/byteorder/swab.h
+++ b/include/linux/byteorder/swab.h
@@ -122,7 +122,6 @@  static __inline__ void __swab32s(__u32 *addr)
 	__arch__swab32s(addr);
 }
 
-#ifdef __BYTEORDER_HAS_U64__
 static __inline__ __attribute__((const)) __u64 __fswab64(__u64 x)
 {
 #  ifdef __SWAB_64_THRU_32__
@@ -141,7 +140,6 @@  static __inline__ void __swab64s(__u64 *addr)
 {
 	__arch__swab64s(addr);
 }
-#endif /* __BYTEORDER_HAS_U64__ */
 
 #if defined(__KERNEL__)
 #define swab16 __swab16