| Message ID | 1352796133-956-1-git-send-email-kraxel@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 13 November 2012 08:42, Gerd Hoffmann <kraxel@redhat.com> wrote: > This patch series fixes the build issues with the internal pixman > submodule. It also adds licensing info to the qemu-pixman.[ch] files. These look OK (and I've tested that we can crosscompile using internal pixman in a separate builddirectory). Reviewed-by: Peter Maydell <peter.maydell@linaro.org> One remaining problem it would be nice to fix (probably as a separate patch given this lot is at the pullreq stage): "make distclean" in qemu doesn't do a distclean in the pixman/ directory. -- PMM
Am 13.11.2012 18:31, schrieb Peter Maydell: > On 13 November 2012 08:42, Gerd Hoffmann <kraxel@redhat.com> wrote: >> This patch series fixes the build issues with the internal pixman >> submodule. It also adds licensing info to the qemu-pixman.[ch] files. > These look OK (and I've tested that we can crosscompile using > internal pixman in a separate builddirectory). > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > > One remaining problem it would be nice to fix (probably as a > separate patch given this lot is at the pullreq stage): > "make distclean" in qemu doesn't do a distclean in the pixman/ > directory. > > -- PMM I just sent reviews for patches 1 and 2. IMHO patch 2 needs some small corrections, and patch 1 can optionally be improved. With at least the corrections, you may add Reviewed-by: Stefan Weil <sw@weilnetz.de> The patch series clearly improves the current build code. As Peter noted, more problems can be addressed later. Cheers Stefan
Gerd Hoffmann <kraxel@redhat.com> writes: > Hi, > > This patch series fixes the build issues with the internal pixman > submodule. It also adds licensing info to the qemu-pixman.[ch] files. > > please pull, > Gerd > > The following changes since commit f5022a135e4309a54d433c69b2a056756b2d0d6b: > > aio: fix aio_ctx_prepare with idle bottom halves (2012-11-12 20:02:09 +0400) > > are available in the git repository at: > git://git.kraxel.org/qemu pixman.v4 Pulled. Thanks. Regards, Anthony Liguori > > Gerd Hoffmann (6): > pixman: add output dir to include path > pixman: pass tools to configure > pixman: disable gtk > pixman: add pass cflags, add -fPIC > pixman: build internal version early > pixman: add licensing info > > Makefile | 2 +- > configure | 17 +++++++++++------ > qemu-pixman.c | 5 +++++ > qemu-pixman.h | 5 +++++ > 4 files changed, 22 insertions(+), 7 deletions(-)
Hi, This patch series fixes the build issues with the internal pixman submodule. It also adds licensing info to the qemu-pixman.[ch] files. please pull, Gerd The following changes since commit f5022a135e4309a54d433c69b2a056756b2d0d6b: aio: fix aio_ctx_prepare with idle bottom halves (2012-11-12 20:02:09 +0400) are available in the git repository at: git://git.kraxel.org/qemu pixman.v4 Gerd Hoffmann (6): pixman: add output dir to include path pixman: pass tools to configure pixman: disable gtk pixman: add pass cflags, add -fPIC pixman: build internal version early pixman: add licensing info Makefile | 2 +- configure | 17 +++++++++++------ qemu-pixman.c | 5 +++++ qemu-pixman.h | 5 +++++ 4 files changed, 22 insertions(+), 7 deletions(-)