Patchwork [U-Boot,V2,1/4] Replace CONFIG_MMC_BOUNCE_BUFFER with CONFIG_BOUNCE_BUFFER in configs

login
register
mail settings
Submitter Stephen Warren
Date Nov. 6, 2012, 9:27 p.m.
Message ID <1352237250-8764-1-git-send-email-swarren@wwwdotorg.org>
Download mbox | patch
Permalink /patch/197547/
State Accepted
Delegated to: Andy Fleming
Headers show

Comments

Stephen Warren - Nov. 6, 2012, 9:27 p.m.
From: Stephen Warren <swarren@nvidia.com>

Commits 6dc71c8 "MMC: MXS: Toggle the generic bounce buffer on the
boards" and 49a627f "MMC: Remove the MMC bounce buffer" replaced
CONFIG_MMC_BOUNCE_BUFFER with CONFIG_BOUNCE_BUFFER, but missed
converting a few boards over to the new option. Fix this.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
v2: New patch.
---
 include/configs/mx6qarm2.h         |    2 +-
 include/configs/mx6qsabre_common.h |    2 +-
 include/configs/mx6qsabrelite.h    |    2 +-
 include/configs/sc_sps_1.h         |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
Simon Glass - Nov. 6, 2012, 10:53 p.m.
On Tue, Nov 6, 2012 at 1:27 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Commits 6dc71c8 "MMC: MXS: Toggle the generic bounce buffer on the
> boards" and 49a627f "MMC: Remove the MMC bounce buffer" replaced
> CONFIG_MMC_BOUNCE_BUFFER with CONFIG_BOUNCE_BUFFER, but missed
> converting a few boards over to the new option. Fix this.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>

Tested on Seaboard, loading a kernel from ext2 partition.

Acked-by: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Stephen Warren - Nov. 15, 2012, 8:34 p.m.
On 11/06/2012 02:27 PM, Stephen Warren wrote:
> Commits 6dc71c8 "MMC: MXS: Toggle the generic bounce buffer on the
> boards" and 49a627f "MMC: Remove the MMC bounce buffer" replaced
> CONFIG_MMC_BOUNCE_BUFFER with CONFIG_BOUNCE_BUFFER, but missed
> converting a few boards over to the new option. Fix this.

Do these patches look good to be applied? I'd like to see them in the
release, since they fix an actual bug on Tegra (buffer corruption, which
definitely leads to /at least/ SD cards being accessed as 1-bit rather
than 4-bit on some Tegra platforms some of the time).

Patch

diff --git a/include/configs/mx6qarm2.h b/include/configs/mx6qarm2.h
index 23562a8..28a3deb 100644
--- a/include/configs/mx6qarm2.h
+++ b/include/configs/mx6qarm2.h
@@ -50,7 +50,7 @@ 
 #define CONFIG_MMC
 #define CONFIG_CMD_MMC
 #define CONFIG_GENERIC_MMC
-#define CONFIG_MMC_BOUNCE_BUFFER
+#define CONFIG_BOUNCE_BUFFER
 #define CONFIG_CMD_FAT
 #define CONFIG_DOS_PARTITION
 
diff --git a/include/configs/mx6qsabre_common.h b/include/configs/mx6qsabre_common.h
index bfb9cd4..a5c93d0 100644
--- a/include/configs/mx6qsabre_common.h
+++ b/include/configs/mx6qsabre_common.h
@@ -45,7 +45,7 @@ 
 #define CONFIG_MMC
 #define CONFIG_CMD_MMC
 #define CONFIG_GENERIC_MMC
-#define CONFIG_MMC_BOUNCE_BUFFER
+#define CONFIG_BOUNCE_BUFFER
 #define CONFIG_CMD_EXT2
 #define CONFIG_CMD_FAT
 #define CONFIG_DOS_PARTITION
diff --git a/include/configs/mx6qsabrelite.h b/include/configs/mx6qsabrelite.h
index b56d7ca..a28d5a5 100644
--- a/include/configs/mx6qsabrelite.h
+++ b/include/configs/mx6qsabrelite.h
@@ -72,7 +72,7 @@ 
 #define CONFIG_MMC
 #define CONFIG_CMD_MMC
 #define CONFIG_GENERIC_MMC
-#define CONFIG_MMC_BOUNCE_BUFFER
+#define CONFIG_BOUNCE_BUFFER
 #define CONFIG_CMD_EXT2
 #define CONFIG_CMD_FAT
 #define CONFIG_DOS_PARTITION
diff --git a/include/configs/sc_sps_1.h b/include/configs/sc_sps_1.h
index f5dc393..cb99d58 100644
--- a/include/configs/sc_sps_1.h
+++ b/include/configs/sc_sps_1.h
@@ -140,7 +140,7 @@ 
 #ifdef CONFIG_CMD_MMC
 #define CONFIG_APBH_DMA
 #define CONFIG_MMC
-#define CONFIG_MMC_BOUNCE_BUFFER
+#define CONFIG_BOUNCE_BUFFER
 #define CONFIG_GENERIC_MMC
 #define CONFIG_MXS_MMC
 #endif