Patchwork [U-Boot,18/20] video: Check for valid FB pointer before clearing

login
register
mail settings
Submitter Simon Glass
Date Nov. 3, 2012, 9:41 p.m.
Message ID <1351978902-23719-19-git-send-email-sjg@chromium.org>
Download mbox | patch
Permalink /patch/196946/
State Accepted, archived
Delegated to: Simon Glass
Headers show

Comments

Simon Glass - Nov. 3, 2012, 9:41 p.m.
From: Duncan Laurie <dlaurie@chromium.org>

This command will start erasing at memory address zero
if there is not a valid framebuffer address that was found
during video_init().

This is a common case with Chrome OS devices in normal mode
when we do not execute the video option rom in coreboot.

Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Signed-off-by: Simon Glass <sjg@chromium.org>
---
 drivers/video/cfb_console.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

Patch

diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
index c8d3e42..2b1f604 100644
--- a/drivers/video/cfb_console.c
+++ b/drivers/video/cfb_console.c
@@ -1976,6 +1976,7 @@  int video_get_screen_columns(void)
 
 void video_clear(void)
 {
-	memsetl(video_fb_address,
-		(VIDEO_VISIBLE_ROWS * VIDEO_LINE_LEN) / sizeof(int), 0);
+	if (video_fb_address)
+		memsetl(video_fb_address,
+			(VIDEO_VISIBLE_ROWS * VIDEO_LINE_LEN) / sizeof(int), 0);
 }