Patchwork [Quantal,SRU,pull-request] Misc linux-backports-modules cleanup

login
register
mail settings
Submitter Leann Ogasawara
Date Oct. 18, 2012, 9 p.m.
Message ID <50806DE5.1060009@canonical.com>
Download mbox
Permalink /patch/192453/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/ogasawara/ubuntu-quantal-lbm.git master

Comments

Leann Ogasawara - Oct. 18, 2012, 9 p.m.
BugLink: http://bugs.launchpad.net/bugs/1068125
BugLink: http://bugs.launchpad.net/bugs/1068283

== Quantal SRU Justification ==
The following pull request performs some misc cleanup for the
linux-backports-modules package for Quantal.

The first patch makes the compat-wireless firmware udev helper file
names version and ABI specific.  We allow multiple upstream versions of
the compat-wireless stack to be packaged and installed.  There currently
exists a potential for conflicts with some of the compat-wireless
firmware udev helper file names due to the files only being ABI
specific, but not version specific, with respect to their naming
convention.  Fix this by making these both version and ABI specific.

The second patch removes all udebs and udeb creation logic from LBM. 
LBM is an elective install and not part of any default server or netboot
installation.  It is therefore unnecessary to provide an
updates-modules.udeb (it was empty anyways) nor have anything to do with
udeb creation in general for that matter.

== Impact ==
LBM is an elective install.  There is no risk of regression for either
of these changes.  I have also built and install tested on both amd64
and i386

== Fix ==

The following changes since commit 86693c1c8498a4b0dc4f5101e4b2df11e5fb0a75:

  UBUNTU: Ubuntu-3.5.0-17.1 (2012-10-17 13:35:58 -0600)

are available in the git repository at:

  git://kernel.ubuntu.com/ogasawara/ubuntu-quantal-lbm.git master

for you to fetch changes up to 216b9a865269aecc91e79694cb2da9222082578e:

  UBUNTU: Remove udebs and udeb creation logic (2012-10-18 12:07:22 -0700)

----------------------------------------------------------------
Leann Ogasawara (2):
      UBUNTU: Make compat-wireless firmware udev helper files version
and ABI specific
      UBUNTU: Remove udebs and udeb creation logic

 debian/d-i/package-list         |    4 ----
 debian/rules                    |   19 ------------------
 debian/rules.d/0-common-vars.mk |    1 -
 debian/rules.d/2-binary-arch.mk |   12 ++++++------
 debian/rules.d/3-udebs.mk       |   41
---------------------------------------
 5 files changed, 6 insertions(+), 71 deletions(-)
 delete mode 100644 debian/d-i/modules/updates-modules
 delete mode 100644 debian/d-i/package-list
 delete mode 100644 debian/rules.d/3-udebs.mk
Herton Ronaldo Krzesinski - Oct. 18, 2012, 9:24 p.m.

Tim Gardner - Oct. 19, 2012, 12:40 p.m.
On 10/18/2012 03:00 PM, Leann Ogasawara wrote:
> BugLink: http://bugs.launchpad.net/bugs/1068125
> BugLink: http://bugs.launchpad.net/bugs/1068283
>
> == Quantal SRU Justification ==
> The following pull request performs some misc cleanup for the
> linux-backports-modules package for Quantal.
>
> The first patch makes the compat-wireless firmware udev helper file
> names version and ABI specific.  We allow multiple upstream versions of
> the compat-wireless stack to be packaged and installed.  There currently
> exists a potential for conflicts with some of the compat-wireless
> firmware udev helper file names due to the files only being ABI
> specific, but not version specific, with respect to their naming
> convention.  Fix this by making these both version and ABI specific.
>

I am not convinced this is necessary. All subsequent CW packages _must_ 
conflict, therefore you can never get into a state of clashing udev 
firmware helpers. Refer to the complex conflict relationships in Lucid LBM.

Its possible that you could get into trouble if you force installed a 
kernel and CW package from another release that had the same ABI. To 
avoid that conflict you'd have to distinguish the udev helpers names by 
release name _and_ ABI. I'm not sure that scenario is worth the complexity.

> The second patch removes all udebs and udeb creation logic from LBM.
> LBM is an elective install and not part of any default server or netboot
> installation.  It is therefore unnecessary to provide an
> updates-modules.udeb (it was empty anyways) nor have anything to do with
> udeb creation in general for that matter.
>

Shouldn't this patch also remove debian/d-i ?

rtg
Andy Whitcroft - Oct. 19, 2012, 1:03 p.m.
On Fri, Oct 19, 2012 at 06:40:08AM -0600, Tim Gardner wrote:

> Shouldn't this patch also remove debian/d-i ?

git only tracks files so as soon as this is empty it will go away.

-apw
Tim Gardner - Oct. 19, 2012, 1:07 p.m.
On 10/19/2012 07:03 AM, Andy Whitcroft wrote:
> On Fri, Oct 19, 2012 at 06:40:08AM -0600, Tim Gardner wrote:
>
>> Shouldn't this patch also remove debian/d-i ?
>
> git only tracks files so as soon as this is empty it will go away.
>
> -apw
>

But it ain't empty. debian/d-i/kernel-versions.in still exists.