Patchwork [U-Boot,V3,02/32] imximage: remove redundant setting of app_dest_ptr

login
register
mail settings
Submitter Troy Kisky
Date Oct. 4, 2012, 1:47 a.m.
Message ID <1349315254-21151-3-git-send-email-troy.kisky@boundarydevices.com>
Download mbox | patch
Permalink /patch/188982/
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Comments

Troy Kisky - Oct. 4, 2012, 1:47 a.m.
Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>

---
v3: split into its own patch
---
 tools/imximage.c |    1 -
 1 file changed, 1 deletion(-)
Stefano Babic - Oct. 8, 2012, 1:17 p.m.
On 04/10/2012 03:47, Troy Kisky wrote:
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> 
> ---
> v3: split into its own patch
> ---
>  tools/imximage.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/imximage.c b/tools/imximage.c
> index c917036..bda1a75 100644
> --- a/tools/imximage.c
> +++ b/tools/imximage.c
> @@ -213,7 +213,6 @@ static void set_imx_hdr_v1(struct imx_header *imxhdr, uint32_t dcd_len,
>  	/* Set magic number */
>  	fhdr_v1->app_code_barker = APP_CODE_BARKER;
>  
> -	fhdr_v1->app_dest_ptr = params->addr;
>  	fhdr_v1->app_dest_ptr = params->ep - imxhdr->flash_offset -
>  		sizeof(struct imx_header);
>  	fhdr_v1->app_code_jump_vector = params->ep;
> 

I think we do not need to discuss on this. I put in in my -next queue
and I will apply it soon.

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
Stefano Babic - Oct. 20, 2012, 3:46 p.m.
Am 04/10/2012 03:47, schrieb Troy Kisky:
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> 
> ---
> v3: split into its own patch
> ---
>  tools/imximage.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/imximage.c b/tools/imximage.c
> index c917036..bda1a75 100644
> --- a/tools/imximage.c
> +++ b/tools/imximage.c
> @@ -213,7 +213,6 @@ static void set_imx_hdr_v1(struct imx_header *imxhdr, uint32_t dcd_len,
>  	/* Set magic number */
>  	fhdr_v1->app_code_barker = APP_CODE_BARKER;
>  
> -	fhdr_v1->app_dest_ptr = params->addr;
>  	fhdr_v1->app_dest_ptr = params->ep - imxhdr->flash_offset -
>  		sizeof(struct imx_header);
>  	fhdr_v1->app_code_jump_vector = params->ep;
> 
Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/tools/imximage.c b/tools/imximage.c
index c917036..bda1a75 100644
--- a/tools/imximage.c
+++ b/tools/imximage.c
@@ -213,7 +213,6 @@  static void set_imx_hdr_v1(struct imx_header *imxhdr, uint32_t dcd_len,
 	/* Set magic number */
 	fhdr_v1->app_code_barker = APP_CODE_BARKER;
 
-	fhdr_v1->app_dest_ptr = params->addr;
 	fhdr_v1->app_dest_ptr = params->ep - imxhdr->flash_offset -
 		sizeof(struct imx_header);
 	fhdr_v1->app_code_jump_vector = params->ep;