Patchwork [U-Boot] arm: omap: Fix switching back to nandecc sw.

login
register
mail settings
Submitter Jeroen Hofstee
Date Aug. 10, 2012, 8:06 p.m.
Message ID <502569C0.7050804@myspectrum.nl>
Download mbox | patch
Permalink /patch/176623/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Jeroen Hofstee - Aug. 10, 2012, 8:06 p.m.
Switching back to nandecc sw fails to write correctly. A fix for this is
already mentioned in the thread below, lets fix it.

mentioned in http://lists.denx.de/pipermail/u-boot/2012-February/119002.html

Signed-off-by: Jeroen Hofstee <jhofstee@victronenergy.com>
---
  drivers/mtd/nand/omap_gpmc.c |    1 +
  1 file changed, 1 insertion(+)
Igor Grinberg - Aug. 12, 2012, 8:12 a.m.
Hi Jeroen,

Thanks for the patch!

On 08/10/12 23:06, Jeroen Hofstee wrote:
> Switching back to nandecc sw fails to write correctly. A fix for this is
> already mentioned in the thread below, lets fix it.
> 
> mentioned in http://lists.denx.de/pipermail/u-boot/2012-February/119002.html

I would expect to have an actual explanation in the commit message
instead of (or along with) the link above and not just something like:
we fix nandecc sw, want to know more, go somewhere else...

> 
> Signed-off-by: Jeroen Hofstee <jhofstee@victronenergy.com>

After the commit message is fixed,

Acked-by: Igor Grinberg <grinberg@compulab.co.il>

> ---
>  drivers/mtd/nand/omap_gpmc.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/nand/omap_gpmc.c b/drivers/mtd/nand/omap_gpmc.c
> index ca868ef..71aec1a 100644
> --- a/drivers/mtd/nand/omap_gpmc.c
> +++ b/drivers/mtd/nand/omap_gpmc.c
> @@ -280,6 +280,7 @@ void omap_nand_switch_ecc(int32_t hardware)
>          omap_hwecc_init(nand);
>          printf("HW ECC selected\n");
>      } else {
> +        nand->ecc.size = 0;
>          nand->ecc.mode = NAND_ECC_SOFT;
>          /* Use mtd default settings */
>          nand->ecc.layout = NULL;
Nikita Kiryanov - Aug. 12, 2012, 12:11 p.m.
Acked-by: Nikita Kiryanov <nikita@compulab.co.il>

On Sun, Aug 12, 2012 at 11:12 AM, Igor Grinberg <grinberg@compulab.co.il>wrote:

> Hi Jeroen,
>
> Thanks for the patch!
>
> On 08/10/12 23:06, Jeroen Hofstee wrote:
> > Switching back to nandecc sw fails to write correctly. A fix for this is
> > already mentioned in the thread below, lets fix it.
> >
> > mentioned in
> http://lists.denx.de/pipermail/u-boot/2012-February/119002.html
>
> I would expect to have an actual explanation in the commit message
> instead of (or along with) the link above and not just something like:
> we fix nandecc sw, want to know more, go somewhere else...
>
> >
> > Signed-off-by: Jeroen Hofstee <jhofstee@victronenergy.com>
>
> After the commit message is fixed,
>
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
>
> > ---
> >  drivers/mtd/nand/omap_gpmc.c |    1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mtd/nand/omap_gpmc.c b/drivers/mtd/nand/omap_gpmc.c
> > index ca868ef..71aec1a 100644
> > --- a/drivers/mtd/nand/omap_gpmc.c
> > +++ b/drivers/mtd/nand/omap_gpmc.c
> > @@ -280,6 +280,7 @@ void omap_nand_switch_ecc(int32_t hardware)
> >          omap_hwecc_init(nand);
> >          printf("HW ECC selected\n");
> >      } else {
> > +        nand->ecc.size = 0;
> >          nand->ecc.mode = NAND_ECC_SOFT;
> >          /* Use mtd default settings */
> >          nand->ecc.layout = NULL;
>
> --
> Regards,
> Igor.
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Jeroen Hofstee - Aug. 14, 2012, 8:36 p.m.
version 2:
     Updated the commit message to include the explanation from the
     original thread.

     For cosmetic reasons, move the added line 2 lines down, so it
     is similiar to the hw case.

     Add original author and maintainer on cc.

Jeroen Hofstee (1):
   arm: omap2+: Fix switching back to nandecc sw.

  drivers/mtd/nand/omap_gpmc.c |    1 +
  1 file changed, 1 insertion(+)
Tom Rini - Aug. 24, 2012, 11:39 p.m.
On Tue, Aug 14, 2012 at 10:36:19PM +0200, Jeroen Hofstee wrote:

> version 2:
>     Updated the commit message to include the explanation from the
>     original thread.
> 
>     For cosmetic reasons, move the added line 2 lines down, so it
>     is similiar to the hw case.
> 
>     Add original author and maintainer on cc.
> 
> Jeroen Hofstee (1):
>   arm: omap2+: Fix switching back to nandecc sw.

Queued up for u-boot-ti/master, thanks!

Patch

diff --git a/drivers/mtd/nand/omap_gpmc.c b/drivers/mtd/nand/omap_gpmc.c
index ca868ef..71aec1a 100644
--- a/drivers/mtd/nand/omap_gpmc.c
+++ b/drivers/mtd/nand/omap_gpmc.c
@@ -280,6 +280,7 @@  void omap_nand_switch_ecc(int32_t hardware)
          omap_hwecc_init(nand);
          printf("HW ECC selected\n");
      } else {
+        nand->ecc.size = 0;
          nand->ecc.mode = NAND_ECC_SOFT;
          /* Use mtd default settings */
          nand->ecc.layout = NULL;