| Message ID | 201207091843.31146.marex@denx.de |
|---|---|
| State | Accepted |
| Delegated to: | Wolfgang Denk |
| Headers | show |
Dear Marek Vasut, In message <201207091843.31146.marex@denx.de> you wrote: > Hello, > > This has been in the usb tree for a while, but I'm hesitant to ask you for > scheduling it into current release. On the other hand, I don't think this will > cause any breakage. > > The following changes since commit 58e22f8a15adec39d24d060180d76a4cbe86a04b: > > fdt: send all dtc output to stderr (2012-07-09 09:05:24 +0200) > > are available in the git repository at: > > git://git.denx.de/u-boot-usb.git master > > for you to fetch changes up to a4dae631bfa848d8a0d1933583ed7e2f6a96cab3: > > CONFIG: EXYNOS5: USB: Enable USB 2.0 on smdk5250 (2012-07-09 18:27:55 +0200) > > ---------------------------------------------------------------- > Rajeshwari Shinde (7): > USB: EXYNOS: Incorporate EHCI review comments > EXYNOS5: Fix system register structure > EXYNOS5: Add structure for PMU registers > USB: EXYNOS: Set USB 2.0 HOST Link mode > EXYNOS: Add power Enable/Disable for USB-EHCI > EXYNOS5: USB: Fix incorrect USB base addresses > CONFIG: EXYNOS5: USB: Enable USB 2.0 on smdk5250 > > arch/arm/cpu/armv7/exynos/power.c | 22 +++ > arch/arm/cpu/armv7/exynos/system.c | 22 +++ > arch/arm/include/asm/arch-exynos/cpu.h | 7 +- > arch/arm/include/asm/arch-exynos/{ehci-s5p.h => ehci.h} | 10 +- > arch/arm/include/asm/arch-exynos/power.h | 626 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > arch/arm/include/asm/arch-exynos/system.h | 4 + > drivers/usb/host/Makefile | 2 +- > drivers/usb/host/{ehci-s5p.c => ehci-exynos.c} | 26 ++- > include/configs/smdk5250.h | 6 + > 9 files changed, 708 insertions(+), 17 deletions(-) > rename arch/arm/include/asm/arch-exynos/{ehci-s5p.h => ehci.h} (90%) > rename drivers/usb/host/{ehci-s5p.c => ehci-exynos.c} (79%) Applied, thanks. Best regards, Wolfgang Denk
Dear Marek, Vivek, Rajeshwari: In message <20120709220446.1BF84202262@gemini.denx.de> I wrote: > > > for you to fetch changes up to a4dae631bfa848d8a0d1933583ed7e2f6a96cab3: > > > > CONFIG: EXYNOS5: USB: Enable USB 2.0 on smdk5250 (2012-07-09 18:27:55 +0200) > > > > ---------------------------------------------------------------- > > Rajeshwari Shinde (7): > > USB: EXYNOS: Incorporate EHCI review comments > > EXYNOS5: Fix system register structure > > EXYNOS5: Add structure for PMU registers > > USB: EXYNOS: Set USB 2.0 HOST Link mode > > EXYNOS: Add power Enable/Disable for USB-EHCI > > EXYNOS5: USB: Fix incorrect USB base addresses > > CONFIG: EXYNOS5: USB: Enable USB 2.0 on smdk5250 > > > > arch/arm/cpu/armv7/exynos/power.c | 22 +++ > > arch/arm/cpu/armv7/exynos/system.c | 22 +++ > > arch/arm/include/asm/arch-exynos/cpu.h | 7 +- > > arch/arm/include/asm/arch-exynos/{ehci-s5p.h => ehci.h} | 10 +- > > arch/arm/include/asm/arch-exynos/power.h | 626 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > arch/arm/include/asm/arch-exynos/system.h | 4 + > > drivers/usb/host/Makefile | 2 +- > > drivers/usb/host/{ehci-s5p.c => ehci-exynos.c} | 26 ++- > > include/configs/smdk5250.h | 6 + > > 9 files changed, 708 insertions(+), 17 deletions(-) > > rename arch/arm/include/asm/arch-exynos/{ehci-s5p.h => ehci.h} (90%) > > rename drivers/usb/host/{ehci-s5p.c => ehci-exynos.c} (79%) These patches break 5 ARM boards: origen s5pc210_universal smdk5250 smdkv310 trats For example: Configuring for origen board... text data bss dec hex filename 158893 3880 205648 368421 59f25 /work/wd/tmp-arm/u-boot 2332 0 0 2332 91c /work/wd/tmp-arm/spl/u-boot-spl system.c: In function 'exynos5_set_usbhost_mode': system.c:32:15: warning: unused variable 'phy_cfg' [-Wunused-variable] system.c: In function 'exynos5_set_usbhost_mode': system.c:32:15: warning: unused variable 'phy_cfg' [-Wunused-variable] Please fix. Thanks. Best regards, Wolfgang Denk
Hello, This has been in the usb tree for a while, but I'm hesitant to ask you for scheduling it into current release. On the other hand, I don't think this will cause any breakage. The following changes since commit 58e22f8a15adec39d24d060180d76a4cbe86a04b: fdt: send all dtc output to stderr (2012-07-09 09:05:24 +0200) are available in the git repository at: git://git.denx.de/u-boot-usb.git master for you to fetch changes up to a4dae631bfa848d8a0d1933583ed7e2f6a96cab3: CONFIG: EXYNOS5: USB: Enable USB 2.0 on smdk5250 (2012-07-09 18:27:55 +0200) ---------------------------------------------------------------- Rajeshwari Shinde (7): USB: EXYNOS: Incorporate EHCI review comments EXYNOS5: Fix system register structure EXYNOS5: Add structure for PMU registers USB: EXYNOS: Set USB 2.0 HOST Link mode EXYNOS: Add power Enable/Disable for USB-EHCI EXYNOS5: USB: Fix incorrect USB base addresses CONFIG: EXYNOS5: USB: Enable USB 2.0 on smdk5250 arch/arm/cpu/armv7/exynos/power.c | 22 +++ arch/arm/cpu/armv7/exynos/system.c | 22 +++ arch/arm/include/asm/arch-exynos/cpu.h | 7 +- arch/arm/include/asm/arch-exynos/{ehci-s5p.h => ehci.h} | 10 +- arch/arm/include/asm/arch-exynos/power.h | 626 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ arch/arm/include/asm/arch-exynos/system.h | 4 + drivers/usb/host/Makefile | 2 +- drivers/usb/host/{ehci-s5p.c => ehci-exynos.c} | 26 ++- include/configs/smdk5250.h | 6 + 9 files changed, 708 insertions(+), 17 deletions(-) rename arch/arm/include/asm/arch-exynos/{ehci-s5p.h => ehci.h} (90%) rename drivers/usb/host/{ehci-s5p.c => ehci-exynos.c} (79%) Best regards, Marek Vasut