| Message ID | 1340573676-29765-1-git-send-email-otavio@ossystems.com.br |
|---|---|
| State | Accepted |
| Commit | e972d72bd7ce944a655328c6a8ef1e75e56490e3 |
| Headers | show |
Dear Otavio Salvador, In message <1340573676-29765-1-git-send-email-otavio@ossystems.com.br> you wrote: > In case an unidentified CPU type is detected it now returns > i.MX??, in a const char. > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> > Cc: Marek Vasut <marex@denx.de> > Cc: Stefano Babic <sbabic@denx.de> > Cc: Fabio Estevam <fabio.estevam@freescale.com> > > Changes since v1: > * use i.MX?? for unidentified CPU type > --- > arch/arm/cpu/armv7/imx-common/cpu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) The change long belongs _below_ the "---" line, not above it, where it becomes part of the commessage. Can you _please_ read http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions ?? You will even find examples there. I asked you to do this before... Best regards, Wolfgang Denk
On Sun, Jun 24, 2012 at 7:12 PM, Wolfgang Denk <wd@denx.de> wrote: > The change long belongs _below_ the "---" line, not above it, where it > becomes part of the commessage. I used git send-email --annotate but probably did something wrong as it didn't ask me to edit this one. I am tracking the changelog on commit log or I forgot what changes I did since last send. > Can you _please_ read > http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions > ?? You will even find examples there. > > I asked you to do this before... I read it; no problem with it and I am trying to get used to it.
diff --git a/arch/arm/cpu/armv7/imx-common/cpu.c b/arch/arm/cpu/armv7/imx-common/cpu.c index b3195dd..e7bd0bf 100644 --- a/arch/arm/cpu/armv7/imx-common/cpu.c +++ b/arch/arm/cpu/armv7/imx-common/cpu.c @@ -66,7 +66,7 @@ char *get_reset_cause(void) #if defined(CONFIG_DISPLAY_CPUINFO) -static char *get_imx_type(u32 imxtype) +static const char *get_imx_type(u32 imxtype) { switch (imxtype) { case 0x63: @@ -80,7 +80,7 @@ static char *get_imx_type(u32 imxtype) case 0x53: return "53"; default: - return "unknown"; + return "??"; } }
In case an unidentified CPU type is detected it now returns i.MX??, in a const char. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> Cc: Marek Vasut <marex@denx.de> Cc: Stefano Babic <sbabic@denx.de> Cc: Fabio Estevam <fabio.estevam@freescale.com> Changes since v1: * use i.MX?? for unidentified CPU type --- arch/arm/cpu/armv7/imx-common/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)