diff mbox

[U-Boot,3/3] omap: emif: fix bug in manufacturer code test

Message ID 1338399488-2095-4-git-send-email-steve@sakoman.com
State Accepted
Commit ad0878a7492928696a93245c1f9190d51eebe549
Delegated to: Tom Rini
Headers show

Commit Message

Steve Sakoman May 30, 2012, 5:38 p.m. UTC 
Code currently tests for <= 0xff.  Micron manufacturer code is 0xff, so
Micron memory will not be detected!

Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 arch/arm/cpu/armv7/omap-common/emif-common.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

SRICHARAN R June 4, 2012, 8:51 a.m. UTC | #1 
> Code currently tests for <= 0xff.  Micron manufacturer code is 0xff, so
> Micron memory will not be detected!
>
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
>  arch/arm/cpu/armv7/omap-common/emif-common.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/omap-common/emif-common.c
> b/arch/arm/cpu/armv7/omap-common/emif-common.c
> index 176520c..46be4e8 100644
> --- a/arch/arm/cpu/armv7/omap-common/emif-common.c
> +++ b/arch/arm/cpu/armv7/omap-common/emif-common.c
> @@ -831,7 +831,7 @@ static u8 is_lpddr2_sdram_present(u32 base, u32 cs,
>  	}
>
>  	mr = get_mr(base, cs, LPDDR2_MR5);
> -	if (mr >= 0xFF) {
> +	if (mr > 0xFF) {
 Looks correct..

Thanks,
 Sricharan
diff mbox

Patch

diff --git a/arch/arm/cpu/armv7/omap-common/emif-common.c b/arch/arm/cpu/armv7/omap-common/emif-common.c
index 176520c..46be4e8 100644
--- a/arch/arm/cpu/armv7/omap-common/emif-common.c
+++ b/arch/arm/cpu/armv7/omap-common/emif-common.c
@@ -831,7 +831,7 @@  static u8 is_lpddr2_sdram_present(u32 base, u32 cs,
 	}
 
 	mr = get_mr(base, cs, LPDDR2_MR5);
-	if (mr >= 0xFF) {
+	if (mr > 0xFF) {
 		/* Mode register value bigger than 8 bit */
 		return 0;
 	}