Patchwork [3/6] UAS: Free status URB when we can't find the SCSI tag.

login
register
mail settings
Submitter Ming Lei
Date April 27, 2012, 9:31 a.m.
Message ID <1335519112-8372-4-git-send-email-ming.lei@canonical.com>
Download mbox | patch
Permalink /patch/155404/
State New
Headers show

Comments

Ming Lei - April 27, 2012, 9:31 a.m.
From: Sarah Sharp <sarah.a.sharp@linux.intel.com>

In the UAS status URB completion handler, we need to free the URB, no
matter what happens.  Fix a bug where we would leak the URB (and its
buffer) if we couldn't find a SCSI command that is associated with this
status phase.

Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/usb/storage/uas.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Patch

diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 28d9b19..9dd4aae 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
@@ -246,8 +246,10 @@  static void uas_stat_cmplt(struct urb *urb)
 		cmnd = sdev->current_cmnd;
 	else
 		cmnd = scsi_find_tag(sdev, tag);
-	if (!cmnd)
+	if (!cmnd) {
+		usb_free_urb(urb);
 		return;
+	}
 
 	switch (iu->iu_id) {
 	case IU_ID_STATUS: