| Message ID | 1331121854-20494-24-git-send-email-amit.virdi@st.com |
|---|---|
| State | Superseded |
| Delegated to: | Stefan Roese |
| Headers | show |
On Wednesday 07 March 2012 13:04:12 Amit Virdi wrote: > Signed-off-by: Amit Virdi <amit.virdi@st.com> > --- > board/spear/common/Makefile | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/board/spear/common/Makefile b/board/spear/common/Makefile > index 11f81e4..48dcfd3 100644 > --- a/board/spear/common/Makefile > +++ b/board/spear/common/Makefile > @@ -29,9 +29,14 @@ endif > > LIB = $(obj)lib$(VENDOR).o > > -COBJS := spr_misc.o > -SOBJS := spr_lowlevel_init.o > +COBJS-$(CONFIG_SPEAR3XX) += spr_misc.o > +COBJS-$(CONFIG_SPEAR600) += spr_misc.o > > +SOBJS-$(CONFIG_SPEAR3XX) += spr_lowlevel_init.o > +SOBJS-$(CONFIG_SPEAR600) += spr_lowlevel_init.o > + > +COBJS := $(sort $(COBJS-y)) > +SOBJS := $(sort $(SOBJS-y)) > SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) > OBJS := $(addprefix $(obj),$(COBJS)) > SOBJS := $(addprefix $(obj),$(SOBJS)) I don't really see the benefit of this patch. Could you please explain a bit more why this is needed/better? Thanks, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de
>> diff --git a/board/spear/common/Makefile b/board/spear/common/Makefile >> index 11f81e4..48dcfd3 100644 >> --- a/board/spear/common/Makefile >> +++ b/board/spear/common/Makefile >> @@ -29,9 +29,14 @@ endif >> >> LIB = $(obj)lib$(VENDOR).o >> >> -COBJS := spr_misc.o >> -SOBJS := spr_lowlevel_init.o >> +COBJS-$(CONFIG_SPEAR3XX) += spr_misc.o >> +COBJS-$(CONFIG_SPEAR600) += spr_misc.o >> >> +SOBJS-$(CONFIG_SPEAR3XX) += spr_lowlevel_init.o >> +SOBJS-$(CONFIG_SPEAR600) += spr_lowlevel_init.o >> + >> +COBJS := $(sort $(COBJS-y)) >> +SOBJS := $(sort $(SOBJS-y)) >> SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) >> OBJS := $(addprefix $(obj),$(COBJS)) >> SOBJS := $(addprefix $(obj),$(SOBJS)) > > I don't really see the benefit of this patch. Could you please explain a bit > more why this is needed/better? > Although it is better this way but the original intention to introduce this patch was to add more features which I didn't added in this patchset since this patchset aims to provide bug fixes in the already existing SPEAr support in u-boot. Maybe, I can drop this patch in V2. Regards Amit Virdi
On Monday 12 March 2012 14:57:50 Amit Virdi wrote: > >> diff --git a/board/spear/common/Makefile b/board/spear/common/Makefile > >> index 11f81e4..48dcfd3 100644 > >> --- a/board/spear/common/Makefile > >> +++ b/board/spear/common/Makefile > >> @@ -29,9 +29,14 @@ endif > >> > >> LIB = $(obj)lib$(VENDOR).o > >> > >> -COBJS := spr_misc.o > >> -SOBJS := spr_lowlevel_init.o > >> +COBJS-$(CONFIG_SPEAR3XX) += spr_misc.o > >> +COBJS-$(CONFIG_SPEAR600) += spr_misc.o > >> > >> +SOBJS-$(CONFIG_SPEAR3XX) += spr_lowlevel_init.o > >> +SOBJS-$(CONFIG_SPEAR600) += spr_lowlevel_init.o > >> + > >> +COBJS := $(sort $(COBJS-y)) > >> +SOBJS := $(sort $(SOBJS-y)) > >> > >> SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) > >> OBJS := $(addprefix $(obj),$(COBJS)) > >> SOBJS := $(addprefix $(obj),$(SOBJS)) > > > > I don't really see the benefit of this patch. Could you please explain a > > bit more why this is needed/better? > > Although it is better this way but the original intention to introduce > this patch was to add more features which I didn't added in this > patchset since this patchset aims to provide bug fixes in the already > existing SPEAr support in u-boot. > > Maybe, I can drop this patch in V2. Yes. Please drop it for now. You can always introduce it (if needed) in a new patch adding the "features" you mentioned above. Thanks, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de
diff --git a/board/spear/common/Makefile b/board/spear/common/Makefile index 11f81e4..48dcfd3 100644 --- a/board/spear/common/Makefile +++ b/board/spear/common/Makefile @@ -29,9 +29,14 @@ endif LIB = $(obj)lib$(VENDOR).o -COBJS := spr_misc.o -SOBJS := spr_lowlevel_init.o +COBJS-$(CONFIG_SPEAR3XX) += spr_misc.o +COBJS-$(CONFIG_SPEAR600) += spr_misc.o +SOBJS-$(CONFIG_SPEAR3XX) += spr_lowlevel_init.o +SOBJS-$(CONFIG_SPEAR600) += spr_lowlevel_init.o + +COBJS := $(sort $(COBJS-y)) +SOBJS := $(sort $(SOBJS-y)) SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) OBJS := $(addprefix $(obj),$(COBJS)) SOBJS := $(addprefix $(obj),$(SOBJS))
Signed-off-by: Amit Virdi <amit.virdi@st.com> --- board/spear/common/Makefile | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-)