| Message ID | 1331121854-20494-21-git-send-email-amit.virdi@st.com |
|---|---|
| State | Superseded |
| Delegated to: | Stefan Roese |
| Headers | show |
On Wednesday 07 March 2012 13:04:09 Amit Virdi wrote: > From: Vipin Kumar <vipin.kumar@st.com> > > Signed-off-by: Vipin Kumar <vipin.kumar@st.com> > Signed-off-by: Amit Virdi <amit.virdi@st.com> > --- > include/configs/spear-common.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/configs/spear-common.h > b/include/configs/spear-common.h index bde99d2..4fb56ba 100644 > --- a/include/configs/spear-common.h > +++ b/include/configs/spear-common.h > @@ -104,6 +104,8 @@ > #define CONFIG_NAND_FSMC > #define CONFIG_SYS_MAX_NAND_DEVICE 1 > #define CONFIG_MTD_NAND_VERIFY_WRITE 1 > +#define CONFIG_SYS_NAND_ONFI_DETECTION 1 > +#define CONFIG_SYS_NAND_QUIET_TEST 1 Remove the "1"'s please. And please also remove CONFIG_MTD_NAND_VERIFY_WRITE. Or is it really needed? I didn't need it on my SPEAr600 boards. And it slows NAND access unnecessarily down. Other than this: Acked-by: Stefan Roese <sr@denx.de> Thanks, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de
Stefan, On 3/7/2012 8:04 PM, Stefan Roese wrote: > On Wednesday 07 March 2012 13:04:09 Amit Virdi wrote: >> From: Vipin Kumar<vipin.kumar@st.com> >> >> Signed-off-by: Vipin Kumar<vipin.kumar@st.com> >> Signed-off-by: Amit Virdi<amit.virdi@st.com> >> --- >> include/configs/spear-common.h | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/include/configs/spear-common.h >> b/include/configs/spear-common.h index bde99d2..4fb56ba 100644 >> --- a/include/configs/spear-common.h >> +++ b/include/configs/spear-common.h >> @@ -104,6 +104,8 @@ >> #define CONFIG_NAND_FSMC >> #define CONFIG_SYS_MAX_NAND_DEVICE 1 >> #define CONFIG_MTD_NAND_VERIFY_WRITE 1 >> +#define CONFIG_SYS_NAND_ONFI_DETECTION 1 >> +#define CONFIG_SYS_NAND_QUIET_TEST 1 > > Remove the "1"'s please. And please also remove CONFIG_MTD_NAND_VERIFY_WRITE. > Or is it really needed? I didn't need it on my SPEAr600 boards. And it slows > NAND access unnecessarily down. > Yes, CONFIG_MTD_NAND_VERIFY_WRITE slows down the NAND access. Since it is only for verification purposes, I'll remove it in V2. Thanks Amit Virdi
diff --git a/include/configs/spear-common.h b/include/configs/spear-common.h index bde99d2..4fb56ba 100644 --- a/include/configs/spear-common.h +++ b/include/configs/spear-common.h @@ -104,6 +104,8 @@ #define CONFIG_NAND_FSMC #define CONFIG_SYS_MAX_NAND_DEVICE 1 #define CONFIG_MTD_NAND_VERIFY_WRITE 1 +#define CONFIG_SYS_NAND_ONFI_DETECTION 1 +#define CONFIG_SYS_NAND_QUIET_TEST 1 /* * Command support defines