| Message ID | 1330294507-6463-5-git-send-email-marex@denx.de |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Stefano Babic |
| Headers | show |
On Sun, Feb 26, 2012 at 7:15 PM, Marek Vasut <marex@denx.de> wrote: > Signed-off-by: Marek Vasut <marex@denx.de> > --- > arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Could you please elaborate a commit message for this? From what I could see this is changing from 0x0f02020a to 0x0f02010a, and it would be nice to have in the commit message an explanation of what this register is, what you are changing and why.
> On Sun, Feb 26, 2012 at 7:15 PM, Marek Vasut <marex@denx.de> wrote: > > Signed-off-by: Marek Vasut <marex@denx.de> > > --- > > arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > Could you please elaborate a commit message for this? > > From what I could see this is changing from 0x0f02020a to 0x0f02010a, > and it would be nice to have in the commit message an explanation of > what this register is, what you are changing and why. If I could get my hands on Office 2010 to open that stupid memory thing supplied by freescale, I would. But since I can't ... basically, this is magic which enables all fourteen address lines. From what I remember, the piece at 0xf << 8 says how many address bits are to be disabled and 0 is prohibited. Since all of them should be enabled now, I don't consider it necessary to poke into this anymore. Or does it break anything for you? M
On Thu, Mar 1, 2012 at 3:34 PM, Marek Vasut <marex@denx.de> wrote: > If I could get my hands on Office 2010 to open that stupid memory thing supplied > by freescale, I would. But since I can't ... basically, this is magic which > enables all fourteen address lines. From what I remember, the piece at 0xf << 8 > says how many address bits are to be disabled and 0 is prohibited. > > Since all of them should be enabled now, I don't consider it necessary to poke > into this anymore. Or does it break anything for you? I haven't had a chance to test it yet. My comment was more towards putting a brief explanation in the commit log.
> On Thu, Mar 1, 2012 at 3:34 PM, Marek Vasut <marex@denx.de> wrote: > > If I could get my hands on Office 2010 to open that stupid memory thing > > supplied by freescale, I would. But since I can't ... basically, this is > > magic which enables all fourteen address lines. From what I remember, > > the piece at 0xf << 8 says how many address bits are to be disabled and > > 0 is prohibited. > > > > Since all of them should be enabled now, I don't consider it necessary to > > poke into this anymore. Or does it break anything for you? > > I haven't had a chance to test it yet. My comment was more towards > putting a brief explanation in the commit log. Well ... it was more verbose than FSL docs ;-) I got your point though, but I'll not be resending it unless completely necessary, I don't see this very important. I'd eventually love this transformed properly to a structure or something.
On 01/03/2012 19:52, Marek Vasut wrote: > Well ... it was more verbose than FSL docs ;-) Well, you are only saying that it is only a little more of nothing... ;-) > I got your point though, but I'll > not be resending it unless completely necessary, I don't see this very > important. I'd eventually love this transformed properly to a structure or > something. Ok - what about if I merge the patch adding in the commit message "enables all fourteen address lines for DRAM" ? Stefano
> On 01/03/2012 19:52, Marek Vasut wrote: > > Well ... it was more verbose than FSL docs ;-) > > Well, you are only saying that it is only a little more of nothing... ;-) > > > I got your point though, but I'll > > not be resending it unless completely necessary, I don't see this very > > important. I'd eventually love this transformed properly to a structure > > or something. > > Ok - what about if I merge the patch adding in the commit message > "enables all fourteen address lines for DRAM" ? > > Stefano Acked-by: Marek Vasut <marek.vasut@gmail.com> and ... Tested-by: Marek Vasut <marek.vasut@gmail.com> ^--- I'm definitelly making enough brownie points with this "Tested-by" to make it to the first place in that category in 2012.03 release :D M
On 26/02/2012 23:15, Marek Vasut wrote: > Signed-off-by: Marek Vasut <marex@denx.de> > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic
diff --git a/arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c b/arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c index 4af9eb7..fd18f70 100644 --- a/arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c +++ b/arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c @@ -39,7 +39,7 @@ uint32_t dram_vals[] = { 0x00000000, 0x00000100, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00010101, 0x01010101, - 0x000f0f01, 0x0f02020a, 0x00000000, 0x00010101, + 0x000f0f01, 0x0f02010a, 0x00000000, 0x00010101, 0x00000100, 0x00000100, 0x00000000, 0x00000002, 0x01010000, 0x05060302, 0x06005003, 0x0a0000c8, 0x02009c40, 0x0000030c, 0x0036a609, 0x031a0612,
Signed-off-by: Marek Vasut <marex@denx.de> --- arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)