| Message ID | 1328888043-16881-1-git-send-email-fabio.estevam@freescale.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
On 10/02/2012 16:34, Fabio Estevam wrote: > MX35PDK board does not need to print CPU revision and reset cause in board file > because this is printed by common code when CONFIG_DISPLAY_CPUINFO is selected > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > Stefano, > > I don't have a mx35pdk board handy to try this. Do not worry, I can test it. Stefano
On 10/02/2012 16:34, Fabio Estevam wrote: > MX35PDK board does not need to print CPU revision and reset cause in board file > because this is printed by common code when CONFIG_DISPLAY_CPUINFO is selected > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- Hi Fabio, > /* Print board revision */ > printf("Board: MX35 PDK %d.0 ", ((get_board_rev() >> 8) + 1) & 0x0F); Now please add a \n here, because the newline is not inserted anymore. The output with your patches is : Board: MX35 PDK 1.0 I2C: ready DRAM: 256 MiB Thanks, Stefano
diff --git a/board/freescale/mx35pdk/mx35pdk.c b/board/freescale/mx35pdk/mx35pdk.c index a5b51a0..5f24fed 100644 --- a/board/freescale/mx35pdk/mx35pdk.c +++ b/board/freescale/mx35pdk/mx35pdk.c @@ -263,10 +263,6 @@ int board_late_init(void) int checkboard(void) { - struct ccm_regs *ccm = - (struct ccm_regs *)IMX_CCM_BASE; - u32 cpu_rev = get_cpu_rev(); - /* * Be sure that I2C is initialized to check * the board revision @@ -276,27 +272,6 @@ int checkboard(void) /* Print board revision */ printf("Board: MX35 PDK %d.0 ", ((get_board_rev() >> 8) + 1) & 0x0F); - /* Print CPU revision */ - printf("i.MX35 %d.%d [", (cpu_rev & 0xF0) >> 4, cpu_rev & 0x0F); - - switch (readl(&ccm->rcsr) & 0x0F) { - case 0x0000: - puts("POR"); - break; - case 0x0002: - puts("JTAG"); - break; - case 0x0004: - puts("RST"); - break; - case 0x0008: - puts("WDT"); - break; - default: - puts("unknown"); - } - puts("]\n"); - return 0; }
MX35PDK board does not need to print CPU revision and reset cause in board file because this is printed by common code when CONFIG_DISPLAY_CPUINFO is selected Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- Stefano, I don't have a mx35pdk board handy to try this. board/freescale/mx35pdk/mx35pdk.c | 25 ------------------------- 1 files changed, 0 insertions(+), 25 deletions(-)