| Message ID | 1328693276-12057-2-git-send-email-B38951@freescale.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Jia Hongtao wrote: > Add sec3.1 support > > Signed-off-by: Jin Qing <b24347@freescale.com> > Signed-off-by: Zhao Chenhui <b35336@freescale.com> > Signed-off-by: Jia Hongtao <B38951@freescale.com> > Signed-off-by: Li Yang <leoli@freescale.com> > --- > arch/powerpc/boot/dts/fsl/mpc8572si-post.dtsi | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/boot/dts/fsl/mpc8572si-post.dtsi b/arch/powerpc/boot/dts/fsl/mpc8572si-post.dtsi > index d44e25a..cdda34f 100644 > --- a/arch/powerpc/boot/dts/fsl/mpc8572si-post.dtsi > +++ b/arch/powerpc/boot/dts/fsl/mpc8572si-post.dtsi > @@ -184,7 +184,7 @@ > /include/ "pq3-etsec1-1.dtsi" > /include/ "pq3-etsec1-2.dtsi" > /include/ "pq3-etsec1-3.dtsi" > -/include/ "pq3-sec3.0-0.dtsi" > +/include/ "pq3-sec3.1-0.dtsi" This is not "adding SEC 3.1 support". This patch is saying that the 8572 DTS was using the *wrong* SEC version. If that's true, you need to explain why it was wrong.
On Wed, 8 Feb 2012 10:39:43 -0600 Timur Tabi <timur@freescale.com> wrote: > Jia Hongtao wrote: > > -/include/ "pq3-sec3.0-0.dtsi" > > +/include/ "pq3-sec3.1-0.dtsi" > > This is not "adding SEC 3.1 support". This patch is saying that the 8572 > DTS was using the *wrong* SEC version. If that's true, you need to > explain why it was wrong. especially since, and according to "MPC8572E PowerQUICCTM III Integrated Host Processor Family Reference Manual, Rev. 2", the 8572 has a SEC 3.0. Kim
You are right, I copied the patch from 2.6 without doing confirm. I will remove this patch. Thanks. -----Original Message----- From: Phillips Kim-R1AAHA Sent: Thursday, February 09, 2012 2:53 AM To: Tabi Timur-B04825 Cc: Jia Hongtao-B38951; linuxppc-dev@lists.ozlabs.org Subject: Re: [linuxppc-release] [PATCH 2/2] powerpc/85xx: update SEC node in dts for MPC8572DS On Wed, 8 Feb 2012 10:39:43 -0600 Timur Tabi <timur@freescale.com> wrote: > Jia Hongtao wrote: > > -/include/ "pq3-sec3.0-0.dtsi" > > +/include/ "pq3-sec3.1-0.dtsi" > > This is not "adding SEC 3.1 support". This patch is saying that the > 8572 DTS was using the *wrong* SEC version. If that's true, you need > to explain why it was wrong. especially since, and according to "MPC8572E PowerQUICCTM III Integrated Host Processor Family Reference Manual, Rev. 2", the 8572 has a SEC 3.0. Kim
diff --git a/arch/powerpc/boot/dts/fsl/mpc8572si-post.dtsi b/arch/powerpc/boot/dts/fsl/mpc8572si-post.dtsi index d44e25a..cdda34f 100644 --- a/arch/powerpc/boot/dts/fsl/mpc8572si-post.dtsi +++ b/arch/powerpc/boot/dts/fsl/mpc8572si-post.dtsi @@ -184,7 +184,7 @@ /include/ "pq3-etsec1-1.dtsi" /include/ "pq3-etsec1-2.dtsi" /include/ "pq3-etsec1-3.dtsi" -/include/ "pq3-sec3.0-0.dtsi" +/include/ "pq3-sec3.1-0.dtsi" /include/ "pq3-mpic.dtsi" /include/ "pq3-mpic-timer-B.dtsi"