diff mbox

[U-Boot,11/11] MIPS: MAKEALL: fix lists for MIPSel and MIPS boards

Message ID 1322143076-20349-12-git-send-email-daniel.schwierzeck@googlemail.com
State Accepted
Headers show

Commit Message

Daniel Schwierzeck Nov. 24, 2011, 1:57 p.m. UTC
Build dbau1550_el only in LIST_au1xx0_el and LIST_mips_el.
Also remove obsolete lists for mips5kc.

Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
Cc: Thomas Lange <thomas@corelatus.se>
---
 MAKEALL |   11 ++---------
 1 files changed, 2 insertions(+), 9 deletions(-)

Comments

Mike Frysinger Nov. 24, 2011, 5:41 p.m. UTC | #1
On Thursday 24 November 2011 08:57:56 Daniel Schwierzeck wrote:
> Build dbau1550_el only in LIST_au1xx0_el and LIST_mips_el.
> Also remove obsolete lists for mips5kc.

if possible, i'd really like to kill off all the specialized mips lists and do 
selection purely based on fields in boards.cfg.
-mike
Marek Vasut Nov. 25, 2011, 8:49 a.m. UTC | #2
> On Thursday 24 November 2011 08:57:56 Daniel Schwierzeck wrote:
> > Build dbau1550_el only in LIST_au1xx0_el and LIST_mips_el.
> > Also remove obsolete lists for mips5kc.
> 
> if possible, i'd really like to kill off all the specialized mips lists and
> do selection purely based on fields in boards.cfg.
> -mike

I have to agree here.
M
Daniel Schwierzeck Nov. 25, 2011, 12:29 p.m. UTC | #3
On Fri, Nov 25, 2011 at 9:49 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
>> On Thursday 24 November 2011 08:57:56 Daniel Schwierzeck wrote:
>> > Build dbau1550_el only in LIST_au1xx0_el and LIST_mips_el.
>> > Also remove obsolete lists for mips5kc.
>>
>> if possible, i'd really like to kill off all the specialized mips lists and
>> do selection purely based on fields in boards.cfg.
>> -mike
>
> I have to agree here.
> M
>

that is currently not possible because -EB and -EL are not properly
handled in CFLAGS and LDFLAGS.
Until this is fixed we have to run MAKEALL twice with mips and mipsel
and different toolchains.
thomas.langer@lantiq.com Nov. 25, 2011, 3:21 p.m. UTC | #4
Hello Daniel,

Daniel Schwierzeck wrote on 2011-11-25:
> On Fri, Nov 25, 2011 at 9:49 AM, Marek Vasut <marek.vasut@gmail.com>
> wrote:
>>> On Thursday 24 November 2011 08:57:56 Daniel Schwierzeck wrote:
>>>> Build dbau1550_el only in LIST_au1xx0_el and LIST_mips_el.
>>>> Also remove obsolete lists for mips5kc.
>>> 
>>> if possible, i'd really like to kill off all the specialized mips
>>> lists and do selection purely based on fields in boards.cfg. -mike
>> 
>> I have to agree here.
>> M
>> 
> 
> that is currently not possible because -EB and -EL are not properly
> handled in CFLAGS and LDFLAGS.
> Until this is fixed we have to run MAKEALL twice with mips and mipsel
> and different toolchains.

I have seen that barebox[1] has got support for MIPS some releases ago.
They define the endianess in the config, so it is easier to handle in the
build process.
Also the handling of compiler and linker options is more optimized[2].

Maybe we should take advantage of it and port some of this over to u-boot?
I think the current handling of -EB and -EL is still from Wolfgangs first
port of a MIPS board.

Best Regards,
Thomas

PS: Sorry for sending multiple times, I have problem to suppress base64 encoding.
   I hope it is okay now.

[1] http://www.barebox.org/
[2] http://git.pengutronix.de/?p=barebox.git;a=blob;f=arch/mips/Makefile;hb=HEAD
Mike Frysinger Nov. 25, 2011, 7:52 p.m. UTC | #5
On Friday 25 November 2011 07:29:57 Daniel Schwierzeck wrote:
> On Fri, Nov 25, 2011 at 9:49 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> >> On Thursday 24 November 2011 08:57:56 Daniel Schwierzeck wrote:
> >> > Build dbau1550_el only in LIST_au1xx0_el and LIST_mips_el.
> >> > Also remove obsolete lists for mips5kc.
> >> 
> >> if possible, i'd really like to kill off all the specialized mips lists
> >> and do selection purely based on fields in boards.cfg.
> > 
> > I have to agree here.
> 
> that is currently not possible because -EB and -EL are not properly
> handled in CFLAGS and LDFLAGS.

can we get this fixed ?  it makes running MAKEALL a pain (i've hit this a few 
times).

are there any mips cores which can run in either endian ?  if so, we should 
add a config option to control this which the top level Makefile can key off of.  
otherwise, should be easy to tweak the subdirs in arch/mips/ to add -EB/-EL as 
needed.

the top level option would be useful for arm boards though as they do have 
processors that can run in either endian ...
-mike
Wolfgang Denk Dec. 9, 2011, 9:53 a.m. UTC | #6
Dear Daniel Schwierzeck,

In message <1322143076-20349-12-git-send-email-daniel.schwierzeck@googlemail.com> you wrote:
> Build dbau1550_el only in LIST_au1xx0_el and LIST_mips_el.
> Also remove obsolete lists for mips5kc.
> 
> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
> Cc: Thomas Lange <thomas@corelatus.se>
> ---
>  MAKEALL |   11 ++---------
>  1 files changed, 2 insertions(+), 9 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/MAKEALL b/MAKEALL
index 95b7cd3..ff761e6 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -379,14 +379,11 @@  LIST_mips4kc="		\
 	vct_premium_onenand_small	\
 "
 
-LIST_mips5kc=""
-
 LIST_au1xx0="		\
 	dbau1000	\
 	dbau1100	\
 	dbau1500	\
 	dbau1550	\
-	dbau1550_el	\
 	gth2		\
 "
 
@@ -400,20 +397,16 @@  LIST_mips="		\
 ## MIPS Systems		(little endian)
 #########################################################################
 
-LIST_mips4kc_el="	\
+LIST_xburst_el="	\
 	qi_lb60		\
 "
 
-LIST_mips5kc_el=""
-
 LIST_au1xx0_el="	\
 	dbau1550_el	\
 	pb1000		\
 "
-
 LIST_mips_el="			\
-	${LIST_mips4kc_el}	\
-	${LIST_mips5kc_el}	\
+	${LIST_xburst_el}	\
 	${LIST_au1xx0_el}	\
 "