Message ID | B0658F55E67EDE4A914644632835B2CAF7E57B@DEUTERIUM.delien.local |
---|---|
State | Accepted |
Delegated to: | Stefano Babic |
Headers | show |
> This patch fixes a small off-by-one bug in the GPIO driver for the mxs > platform that allowed the selection gpio pins of one bank more than the > SoC actually has. > > Signed-off-by: Robert Deliën <robert at delien.nl> > > diff --git a/drivers/gpio/mxs_gpio.c b/drivers/gpio/mxs_gpio.c > index b7e9591..539738b 100644 > --- a/drivers/gpio/mxs_gpio.c > +++ b/drivers/gpio/mxs_gpio.c > @@ -120,7 +120,7 @@ int gpio_direction_output(int gp, int value) > > int gpio_request(int gp, const char *label) > { > - if (PAD_BANK(gp) > PINCTRL_BANKS) > + if (PAD_BANK(gp) >= PINCTRL_BANKS) > return -EINVAL; > > return 0; Acked-by: Marek Vasut <marek.vasut@gmail.com> I'd like to see Stefano review this too. M
> > Sure, I wrote the code, I know what it does and where you see the > > problem. It's just to be dead sure. Anyway, I acked it so it means I > > agree with the change. > > Of course. Thanks. Hence my elaboration, to make your checks easier. Please, ALWAYS Cc the mailing list
> This patch fixes a small off-by-one bug in the GPIO driver for the mxs > platform that allowed the selection gpio pins of one bank more than the > SoC actually has. > > Signed-off-by: Robert Deliën <robert at delien.nl> > > diff --git a/drivers/gpio/mxs_gpio.c b/drivers/gpio/mxs_gpio.c > index b7e9591..539738b 100644 > --- a/drivers/gpio/mxs_gpio.c > +++ b/drivers/gpio/mxs_gpio.c > @@ -120,7 +120,7 @@ int gpio_direction_output(int gp, int value) > > int gpio_request(int gp, const char *label) > { > - if (PAD_BANK(gp) > PINCTRL_BANKS) > + if (PAD_BANK(gp) >= PINCTRL_BANKS) > return -EINVAL; > > return 0; Stefano, can you please apply ? Acked-by: Marek Vasut <marek.vasut@gmail.com>
On 22/11/2011 15:14, Robert Deliën wrote: > This patch fixes a small off-by-one bug in the GPIO driver for the mxs platform that allowed the selection gpio pins of one bank more than the SoC actually has. > > Signed-off-by: Robert Deliën <robert at delien.nl> > > diff --git a/drivers/gpio/mxs_gpio.c b/drivers/gpio/mxs_gpio.c > index b7e9591..539738b 100644 > --- a/drivers/gpio/mxs_gpio.c > +++ b/drivers/gpio/mxs_gpio.c > @@ -120,7 +120,7 @@ int gpio_direction_output(int gp, int value) > > int gpio_request(int gp, const char *label) > { > - if (PAD_BANK(gp) > PINCTRL_BANKS) > + if (PAD_BANK(gp) >= PINCTRL_BANKS) > return -EINVAL; > > return 0; > Applied to u-boot-imx, thanks. Best regards, Stefano Babic
diff --git a/drivers/gpio/mxs_gpio.c b/drivers/gpio/mxs_gpio.c index b7e9591..539738b 100644 --- a/drivers/gpio/mxs_gpio.c +++ b/drivers/gpio/mxs_gpio.c @@ -120,7 +120,7 @@ int gpio_direction_output(int gp, int value) int gpio_request(int gp, const char *label) { - if (PAD_BANK(gp) > PINCTRL_BANKS) + if (PAD_BANK(gp) >= PINCTRL_BANKS) return -EINVAL; return 0;
This patch fixes a small off-by-one bug in the GPIO driver for the mxs platform that allowed the selection gpio pins of one bank more than the SoC actually has. Signed-off-by: Robert Deliën <robert at delien.nl>