diff mbox series

[PATCH-for-5.0?] .github: Enable repo-lockdown bot to refuse GitHub pull requests

Message ID 20200406214125.18538-1-f4bug@amsat.org
State New
Headers show
Series [PATCH-for-5.0?] .github: Enable repo-lockdown bot to refuse GitHub pull requests | expand

Commit Message

Philippe Mathieu-Daudé April 6, 2020, 9:41 p.m. UTC
Some GitHub users try to open pull requests against the GitHub
mirror. Unfortunate these get ignored until eventually someone
notices and closes the request.

Enable the 'Repo Lockdown' [*] 3rd party bot which can autorespond
to pull requests with a friendly comment, close the request, and
then lock it to prevent further comments.

[*] https://github.com/dessant/repo-lockdown

Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
Repo Lockdown is enabled on https://github.com/qemu/qemu/
---
 .github/lockdown.yml | 35 +++++++++++++++++++++++++++++++++++
 MAINTAINERS          |  1 +
 2 files changed, 36 insertions(+)
 create mode 100644 .github/lockdown.yml

Comments

John Snow April 6, 2020, 9:57 p.m. UTC | #1
On 4/6/20 5:41 PM, Philippe Mathieu-Daudé wrote:
> Some GitHub users try to open pull requests against the GitHub
> mirror. Unfortunate these get ignored until eventually someone
> notices and closes the request.
> 
> Enable the 'Repo Lockdown' [*] 3rd party bot which can autorespond
> to pull requests with a friendly comment, close the request, and
> then lock it to prevent further comments.
> 
> [*] https://github.com/dessant/repo-lockdown
> 
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Repo Lockdown is enabled on https://github.com/qemu/qemu/
> ---
>  .github/lockdown.yml | 35 +++++++++++++++++++++++++++++++++++
>  MAINTAINERS          |  1 +
>  2 files changed, 36 insertions(+)
>  create mode 100644 .github/lockdown.yml
> 
> diff --git a/.github/lockdown.yml b/.github/lockdown.yml
> new file mode 100644
> index 0000000000..94472d1256
> --- /dev/null
> +++ b/.github/lockdown.yml
> @@ -0,0 +1,35 @@
> +# Configuration for Repo Lockdown - https://github.com/dessant/repo-lockdown
> +
> +# Close issues and pull requests
> +close: true
> +
> +# Lock issues and pull requests
> +lock: true
> +
> +issues:
> +  comment: |
> +    Thank you for your interest in the QEMU project.
> +
> +    This repository is a read-only mirror of the project's master
> +    repostories hosted on https://git.qemu.org/git/qemu.git.
> +    The project does not process issues filed on GitHub.
> +
> +    The project issues are tracked on Launchpad:
> +    https://bugs.launchpad.net/qemu
> +
> +    QEMU welcomes bug report contributions. You can fill new ones on:
> +    https://bugs.launchpad.net/qemu/+filebug
> +
> +pulls:
> +  comment: |
> +    Thank you for your interest in the QEMU project.
> +
> +    This repository is a read-only mirror of the project's master
> +    repostories hosted on https://git.qemu.org/git/qemu.git.
> +    The project does not process merge requests filed on GitHub.
> +
> +    QEMU welcomes contributions of code (either fixing bugs or adding new
> +    functionality). However, we get a lot of patches, and so we have some
> +    guidelines about submitting patches described in our Wiki:
> +    https://wiki.qemu.org/Contribute/SubmitAPatch and
> +    https://wiki.qemu.org/Contribute/FAQ
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9d156d73b3..0559e84790 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2833,6 +2833,7 @@ M: Alex Bennée <alex.bennee@linaro.org>
>  M: Fam Zheng <fam@euphon.net>
>  R: Philippe Mathieu-Daudé <philmd@redhat.com>
>  S: Maintained
> +F: .github/lockdown.yml
>  F: .travis.yml
>  F: scripts/travis/
>  F: .shippable.yml
> 

Looks good, and I'd be happy with this as-is, assuming this is enough to
enable it.

Reviewed-by: John Snow <jsnow@redhat.com>
Alex Bennée April 7, 2020, 12:38 p.m. UTC | #2
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Some GitHub users try to open pull requests against the GitHub
> mirror. Unfortunate these get ignored until eventually someone
> notices and closes the request.
>
> Enable the 'Repo Lockdown' [*] 3rd party bot which can autorespond
> to pull requests with a friendly comment, close the request, and
> then lock it to prevent further comments.
>
> [*] https://github.com/dessant/repo-lockdown
>
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Queued to pr/070420-misc-fixes-1, thanks.

> ---
> Repo Lockdown is enabled on https://github.com/qemu/qemu/
> ---
>  .github/lockdown.yml | 35 +++++++++++++++++++++++++++++++++++
>  MAINTAINERS          |  1 +
>  2 files changed, 36 insertions(+)
>  create mode 100644 .github/lockdown.yml
>
> diff --git a/.github/lockdown.yml b/.github/lockdown.yml
> new file mode 100644
> index 0000000000..94472d1256
> --- /dev/null
> +++ b/.github/lockdown.yml
> @@ -0,0 +1,35 @@
> +# Configuration for Repo Lockdown - https://github.com/dessant/repo-lockdown
> +
> +# Close issues and pull requests
> +close: true
> +
> +# Lock issues and pull requests
> +lock: true
> +
> +issues:
> +  comment: |
> +    Thank you for your interest in the QEMU project.
> +
> +    This repository is a read-only mirror of the project's master
> +    repostories hosted on https://git.qemu.org/git/qemu.git.
> +    The project does not process issues filed on GitHub.
> +
> +    The project issues are tracked on Launchpad:
> +    https://bugs.launchpad.net/qemu
> +
> +    QEMU welcomes bug report contributions. You can fill new ones on:
> +    https://bugs.launchpad.net/qemu/+filebug
> +
> +pulls:
> +  comment: |
> +    Thank you for your interest in the QEMU project.
> +
> +    This repository is a read-only mirror of the project's master
> +    repostories hosted on https://git.qemu.org/git/qemu.git.
> +    The project does not process merge requests filed on GitHub.
> +
> +    QEMU welcomes contributions of code (either fixing bugs or adding new
> +    functionality). However, we get a lot of patches, and so we have some
> +    guidelines about submitting patches described in our Wiki:
> +    https://wiki.qemu.org/Contribute/SubmitAPatch and
> +    https://wiki.qemu.org/Contribute/FAQ
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9d156d73b3..0559e84790 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2833,6 +2833,7 @@ M: Alex Bennée <alex.bennee@linaro.org>
>  M: Fam Zheng <fam@euphon.net>
>  R: Philippe Mathieu-Daudé <philmd@redhat.com>
>  S: Maintained
> +F: .github/lockdown.yml
>  F: .travis.yml
>  F: scripts/travis/
>  F: .shippable.yml
Peter Maydell April 7, 2020, 12:53 p.m. UTC | #3
On Mon, 6 Apr 2020 at 22:42, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Some GitHub users try to open pull requests against the GitHub
> mirror. Unfortunate these get ignored until eventually someone
> notices and closes the request.
>
> Enable the 'Repo Lockdown' [*] 3rd party bot which can autorespond
> to pull requests with a friendly comment, close the request, and
> then lock it to prevent further comments.
>
> [*] https://github.com/dessant/repo-lockdown
>
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Repo Lockdown is enabled on https://github.com/qemu/qemu/
> ---
>  .github/lockdown.yml | 35 +++++++++++++++++++++++++++++++++++
>  MAINTAINERS          |  1 +
>  2 files changed, 36 insertions(+)
>  create mode 100644 .github/lockdown.yml
>
> diff --git a/.github/lockdown.yml b/.github/lockdown.yml
> new file mode 100644
> index 0000000000..94472d1256
> --- /dev/null
> +++ b/.github/lockdown.yml
> @@ -0,0 +1,35 @@
> +# Configuration for Repo Lockdown - https://github.com/dessant/repo-lockdown
> +
> +# Close issues and pull requests
> +close: true
> +
> +# Lock issues and pull requests
> +lock: true
> +
> +issues:
> +  comment: |
> +    Thank you for your interest in the QEMU project.
> +
> +    This repository is a read-only mirror of the project's master
> +    repostories hosted on https://git.qemu.org/git/qemu.git.
> +    The project does not process issues filed on GitHub.
> +
> +    The project issues are tracked on Launchpad:
> +    https://bugs.launchpad.net/qemu
> +
> +    QEMU welcomes bug report contributions. You can fill new ones on:

"file"

> +    https://bugs.launchpad.net/qemu/+filebug
> +
> +pulls:
> +  comment: |
> +    Thank you for your interest in the QEMU project.
> +
> +    This repository is a read-only mirror of the project's master
> +    repostories hosted on https://git.qemu.org/git/qemu.git.
> +    The project does not process merge requests filed on GitHub.
> +
> +    QEMU welcomes contributions of code (either fixing bugs or adding new
> +    functionality). However, we get a lot of patches, and so we have some
> +    guidelines about submitting patches described in our Wiki:
> +    https://wiki.qemu.org/Contribute/SubmitAPatch and
> +    https://wiki.qemu.org/Contribute/FAQ

Maybe include a reference to the mailing list here too?

thnaks
-- PMM
Alex Bennée April 7, 2020, 2:02 p.m. UTC | #4
Peter Maydell <peter.maydell@linaro.org> writes:

> On Mon, 6 Apr 2020 at 22:42, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> Some GitHub users try to open pull requests against the GitHub
>> mirror. Unfortunate these get ignored until eventually someone
>> notices and closes the request.
>>
>> Enable the 'Repo Lockdown' [*] 3rd party bot which can autorespond
>> to pull requests with a friendly comment, close the request, and
>> then lock it to prevent further comments.
>>
>> [*] https://github.com/dessant/repo-lockdown
>>
>> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> Repo Lockdown is enabled on https://github.com/qemu/qemu/
>> ---
>>  .github/lockdown.yml | 35 +++++++++++++++++++++++++++++++++++
>>  MAINTAINERS          |  1 +
>>  2 files changed, 36 insertions(+)
>>  create mode 100644 .github/lockdown.yml
>>
>> diff --git a/.github/lockdown.yml b/.github/lockdown.yml
>> new file mode 100644
>> index 0000000000..94472d1256
>> --- /dev/null
>> +++ b/.github/lockdown.yml
>> @@ -0,0 +1,35 @@
>> +# Configuration for Repo Lockdown - https://github.com/dessant/repo-lockdown
>> +
>> +# Close issues and pull requests
>> +close: true
>> +
>> +# Lock issues and pull requests
>> +lock: true
>> +
>> +issues:
>> +  comment: |
>> +    Thank you for your interest in the QEMU project.
>> +
>> +    This repository is a read-only mirror of the project's master
>> +    repostories hosted on https://git.qemu.org/git/qemu.git.
>> +    The project does not process issues filed on GitHub.
>> +
>> +    The project issues are tracked on Launchpad:
>> +    https://bugs.launchpad.net/qemu
>> +
>> +    QEMU welcomes bug report contributions. You can fill new ones on:
>
> "file"
>
>> +    https://bugs.launchpad.net/qemu/+filebug
>> +
>> +pulls:
>> +  comment: |
>> +    Thank you for your interest in the QEMU project.
>> +
>> +    This repository is a read-only mirror of the project's master
>> +    repostories hosted on https://git.qemu.org/git/qemu.git.
>> +    The project does not process merge requests filed on GitHub.
>> +
>> +    QEMU welcomes contributions of code (either fixing bugs or adding new
>> +    functionality). However, we get a lot of patches, and so we have some
>> +    guidelines about submitting patches described in our Wiki:
>> +    https://wiki.qemu.org/Contribute/SubmitAPatch and
>> +    https://wiki.qemu.org/Contribute/FAQ
>
> Maybe include a reference to the mailing list here too?

I'll amend the patch.

>
> thnaks
> -- PMM
diff mbox series

Patch

diff --git a/.github/lockdown.yml b/.github/lockdown.yml
new file mode 100644
index 0000000000..94472d1256
--- /dev/null
+++ b/.github/lockdown.yml
@@ -0,0 +1,35 @@ 
+# Configuration for Repo Lockdown - https://github.com/dessant/repo-lockdown
+
+# Close issues and pull requests
+close: true
+
+# Lock issues and pull requests
+lock: true
+
+issues:
+  comment: |
+    Thank you for your interest in the QEMU project.
+
+    This repository is a read-only mirror of the project's master
+    repostories hosted on https://git.qemu.org/git/qemu.git.
+    The project does not process issues filed on GitHub.
+
+    The project issues are tracked on Launchpad:
+    https://bugs.launchpad.net/qemu
+
+    QEMU welcomes bug report contributions. You can fill new ones on:
+    https://bugs.launchpad.net/qemu/+filebug
+
+pulls:
+  comment: |
+    Thank you for your interest in the QEMU project.
+
+    This repository is a read-only mirror of the project's master
+    repostories hosted on https://git.qemu.org/git/qemu.git.
+    The project does not process merge requests filed on GitHub.
+
+    QEMU welcomes contributions of code (either fixing bugs or adding new
+    functionality). However, we get a lot of patches, and so we have some
+    guidelines about submitting patches described in our Wiki:
+    https://wiki.qemu.org/Contribute/SubmitAPatch and
+    https://wiki.qemu.org/Contribute/FAQ
diff --git a/MAINTAINERS b/MAINTAINERS
index 9d156d73b3..0559e84790 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2833,6 +2833,7 @@  M: Alex Bennée <alex.bennee@linaro.org>
 M: Fam Zheng <fam@euphon.net>
 R: Philippe Mathieu-Daudé <philmd@redhat.com>
 S: Maintained
+F: .github/lockdown.yml
 F: .travis.yml
 F: scripts/travis/
 F: .shippable.yml