diff mbox series

[3/8] package/python3-regex: add special package variant for the host build

Message ID 20200323104909.16765-3-yegorslists@googlemail.com
State Accepted
Headers show
Series [1/8] package/python-psutil: add host variant | expand

Commit Message

Yegor Yefremov March 23, 2020, 10:49 a.m. UTC
From: Yegor Yefremov <yegorslists@googlemail.com>

Needed to build mongodb.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 package/python3-regex/python3-regex.hash |  1 +
 package/python3-regex/python3-regex.mk   | 17 +++++++++++++++++
 2 files changed, 18 insertions(+)
 create mode 120000 package/python3-regex/python3-regex.hash
 create mode 100644 package/python3-regex/python3-regex.mk

Comments

Romain Naour March 24, 2020, 9:50 p.m. UTC | #1
Hi Yegor,

Le 23/03/2020 à 11:49, yegorslists@googlemail.com a écrit :
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Needed to build mongodb.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  package/python3-regex/python3-regex.hash |  1 +
>  package/python3-regex/python3-regex.mk   | 17 +++++++++++++++++
>  2 files changed, 18 insertions(+)
>  create mode 120000 package/python3-regex/python3-regex.hash
>  create mode 100644 package/python3-regex/python3-regex.mk
> 
> diff --git a/package/python3-regex/python3-regex.hash b/package/python3-regex/python3-regex.hash
> new file mode 120000
> index 0000000000..274f4dc277
> --- /dev/null
> +++ b/package/python3-regex/python3-regex.hash
> @@ -0,0 +1 @@
> +../python-regex/python-regex.hash
> \ No newline at end of file
> diff --git a/package/python3-regex/python3-regex.mk b/package/python3-regex/python3-regex.mk
> new file mode 100644
> index 0000000000..a2f67a144a
> --- /dev/null
> +++ b/package/python3-regex/python3-regex.mk
> @@ -0,0 +1,17 @@
> +################################################################################
> +#
> +# python3-regex
> +#
> +################################################################################
> +
> +# Please keep in sync with
> +# package/python-regex/python-regex.mk
> +PYTHON3_REGEX_VERSION = 2020.2.20
> +PYTHON3_REGEX_SOURCE = regex-$(PYTHON3_REGEX_VERSION).tar.gz
> +PYTHON3_REGEX_SITE = https://files.pythonhosted.org/packages/e8/76/8ac7f467617b9cfbafcef3c76df6f22b15de654a62bea719792b00a83195
> +PYTHON3_REGEX_SETUP_TYPE = setuptools
> +PYTHON3_REGEX_LICENSE = CNRI-Python
> +HOST_PYTHON3_REGEX_DL_SUBDIR = python-regex
> +HOST_PYTHON3_REGEX_NEEDS_HOST_PYTHON = python3

I don't think we should continue to add more python3 packages to provide host
python3 modules. Titouan what is the status of python2 removal ?

Best regards,
Romain

> +
> +$(eval $(host-python-package))
>
Thomas Petazzoni April 24, 2020, 12:59 p.m. UTC | #2
On Mon, 23 Mar 2020 11:49:04 +0100
yegorslists@googlemail.com wrote:

> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Needed to build mongodb.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  package/python3-regex/python3-regex.hash |  1 +
>  package/python3-regex/python3-regex.mk   | 17 +++++++++++++++++
>  2 files changed, 18 insertions(+)
>  create mode 120000 package/python3-regex/python3-regex.hash
>  create mode 100644 package/python3-regex/python3-regex.mk

Like Romain, I don't really like that we're adding more and more
duplicated packages for host-python3, but we don't really have a good
solution today. And since the mid-term plan is to get rid of Python
2.x, I don't think it's very useful to implement an alternate solution
now.

> +# Please keep in sync with
> +# package/python-regex/python-regex.mk

I've put this comment on one line, and also added the comment in
package/python-regex/python-regex.mk.

Applied with this change. Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/python3-regex/python3-regex.hash b/package/python3-regex/python3-regex.hash
new file mode 120000
index 0000000000..274f4dc277
--- /dev/null
+++ b/package/python3-regex/python3-regex.hash
@@ -0,0 +1 @@ 
+../python-regex/python-regex.hash
\ No newline at end of file
diff --git a/package/python3-regex/python3-regex.mk b/package/python3-regex/python3-regex.mk
new file mode 100644
index 0000000000..a2f67a144a
--- /dev/null
+++ b/package/python3-regex/python3-regex.mk
@@ -0,0 +1,17 @@ 
+################################################################################
+#
+# python3-regex
+#
+################################################################################
+
+# Please keep in sync with
+# package/python-regex/python-regex.mk
+PYTHON3_REGEX_VERSION = 2020.2.20
+PYTHON3_REGEX_SOURCE = regex-$(PYTHON3_REGEX_VERSION).tar.gz
+PYTHON3_REGEX_SITE = https://files.pythonhosted.org/packages/e8/76/8ac7f467617b9cfbafcef3c76df6f22b15de654a62bea719792b00a83195
+PYTHON3_REGEX_SETUP_TYPE = setuptools
+PYTHON3_REGEX_LICENSE = CNRI-Python
+HOST_PYTHON3_REGEX_DL_SUBDIR = python-regex
+HOST_PYTHON3_REGEX_NEEDS_HOST_PYTHON = python3
+
+$(eval $(host-python-package))