diff mbox series

[2/2] package/libostree: add introspection support

Message ID 20200320222359.88689-2-aduskett@gmail.com
State Rejected
Headers show
Series [1/2] package/gobject-introspection/g-ir-scanner: do not set default compiler values | expand

Commit Message

Adam Duskett March 20, 2020, 10:23 p.m. UTC 
From: Adam Duskett <Aduskett@gmail.com>

If gobject-introspection is selected, explicitly set --enable-introspection in
the configure options and add a dependency for gobject-introspection.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
 package/libostree/libostree.mk | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Yann E. MORIN March 22, 2020, 9:31 a.m. UTC | #1 
Adam, All,

On 2020-03-20 15:23 -0700, aduskett@gmail.com spake thusly:
> From: Adam Duskett <Aduskett@gmail.com>
> 
> If gobject-introspection is selected, explicitly set --enable-introspection in
> the configure options and add a dependency for gobject-introspection.
> 
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>

I've sent an alternate proposal that replaces this patch, nad gets away
with the previous one too:
    https://patchwork.ozlabs.org/patch/1259614/

Regards,
Yann E. MORIN.

> ---
>  package/libostree/libostree.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/libostree/libostree.mk b/package/libostree/libostree.mk
> index bdbe6b5aba..63e6bbfde3 100644
> --- a/package/libostree/libostree.mk
> +++ b/package/libostree/libostree.mk
> @@ -30,6 +30,13 @@ else
>  LIBOSTREE_CONF_OPTS += --without-openssl
>  endif
>  
> +ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
> +LIBOSTREE_CONF_OPTS += --enable-introspection
> +LIBOSTREE_DEPENDENCIES += gobject-introspection
> +else
> +LIBOSTREE_CONF_OPTS += --disable-introspection
> +endif
> +
>  # Avahi support needs libavahi-client, which is built by avahi if avahi-daemon
>  # and dbus is selected. Since there is no BR2_PACKAGE_LIBAVAHI_CLIENT config
>  # option yet, use the avahi-daemon and dbus config symbols to check for
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/package/libostree/libostree.mk b/package/libostree/libostree.mk
index bdbe6b5aba..63e6bbfde3 100644
--- a/package/libostree/libostree.mk
+++ b/package/libostree/libostree.mk
@@ -30,6 +30,13 @@  else
 LIBOSTREE_CONF_OPTS += --without-openssl
 endif
 
+ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
+LIBOSTREE_CONF_OPTS += --enable-introspection
+LIBOSTREE_DEPENDENCIES += gobject-introspection
+else
+LIBOSTREE_CONF_OPTS += --disable-introspection
+endif
+
 # Avahi support needs libavahi-client, which is built by avahi if avahi-daemon
 # and dbus is selected. Since there is no BR2_PACKAGE_LIBAVAHI_CLIENT config
 # option yet, use the avahi-daemon and dbus config symbols to check for