| Message ID | 20200311133504.13911-1-p.debruijn@unilogic.nl |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/collectd: make network crypto support discoverable | expand |
On Wed, 11 Mar 2020 14:35:04 +0100 Pascal de Bruijn <p.debruijn@unilogic.nl> wrote: > before it was completely non-obvious how to get crypto support > in collectd's network module > > this introduces a collectd config option which makes sure > gcrypt is built, and can't be accidentally unselected > resulting in an accidental non-crypto build of collectd > > Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl> > --- > package/collectd/Config.in | 7 +++++++ > 1 file changed, 7 insertions(+) Applied to master, thanks. Thomas
>>>>> "Pascal" == Pascal de Bruijn <p.debruijn@unilogic.nl> writes: > before it was completely non-obvious how to get crypto support > in collectd's network module > this introduces a collectd config option which makes sure > gcrypt is built, and can't be accidentally unselected > resulting in an accidental non-crypto build of collectd > Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl> > --- > package/collectd/Config.in | 7 +++++++ > 1 file changed, 7 insertions(+) > diff --git a/package/collectd/Config.in b/package/collectd/Config.in > index 303b5dc01b..4b34ec60eb 100644 > --- a/package/collectd/Config.in > +++ b/package/collectd/Config.in > @@ -603,6 +603,13 @@ config BR2_PACKAGE_COLLECTD_NETWORK > help > Send/receive values from other instances of collectd. > +config BR2_PACKAGE_COLLECTD_NETWORK_GCRYPT > + bool "crypto support" > + depends on BR2_PACKAGE_COLLECTD_NETWORK > + select BR2_PACKAGE_LIBGCRYPT > + help > + Enable crypto support It would IMHO also make sense to change the conditional in collectd.mk to use this symbol so crypto support is really disabled if this option is turned off, otherwise it is just confusing in the other direction now.
On Tue, 07 Apr 2020 18:06:19 +0200 Peter Korsgaard <peter@korsgaard.com> wrote: > > +config BR2_PACKAGE_COLLECTD_NETWORK_GCRYPT > > + bool "crypto support" > > + depends on BR2_PACKAGE_COLLECTD_NETWORK > > + select BR2_PACKAGE_LIBGCRYPT > > + help > > + Enable crypto support > > It would IMHO also make sense to change the conditional in collectd.mk > to use this symbol so crypto support is really disabled if this option > is turned off, otherwise it is just confusing in the other direction > now. Indeed. Pascal, could you send a patch implementing this? Thanks, Thomas
diff --git a/package/collectd/Config.in b/package/collectd/Config.in index 303b5dc01b..4b34ec60eb 100644 --- a/package/collectd/Config.in +++ b/package/collectd/Config.in @@ -603,6 +603,13 @@ config BR2_PACKAGE_COLLECTD_NETWORK help Send/receive values from other instances of collectd. +config BR2_PACKAGE_COLLECTD_NETWORK_GCRYPT + bool "crypto support" + depends on BR2_PACKAGE_COLLECTD_NETWORK + select BR2_PACKAGE_LIBGCRYPT + help + Enable crypto support + config BR2_PACKAGE_COLLECTD_RRDTOOL bool "rrdtool" depends on BR2_USE_WCHAR # rrdtool
before it was completely non-obvious how to get crypto support in collectd's network module this introduces a collectd config option which makes sure gcrypt is built, and can't be accidentally unselected resulting in an accidental non-crypto build of collectd Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl> --- package/collectd/Config.in | 7 +++++++ 1 file changed, 7 insertions(+)