Patchwork [U-Boot,12/13] board/esd/cpci750/cpci750.c: Fix error handling

login
register
mail settings
Submitter Wolfgang Denk
Date Nov. 9, 2011, 7:29 p.m.
Message ID <1320866946-28235-12-git-send-email-wd@denx.de>
Download mbox | patch
Permalink /patch/124677/
State Accepted
Commit be51c5c98b8d705a1795d00668344cfade8d6545
Headers show

Comments

Wolfgang Denk - Nov. 9, 2011, 7:29 p.m.
ThE code recorded error conditions but did not pass these on to the
higher level caller.  Fixing this fixes also this build warning:
cpci750.c: In function 'do_loadpci':
cpci750.c:569:6: warning: variable 'status' set but not used
[-Wunused-but-set-variable]

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Reinhard Arlt <reinhard.arlt@esd-electronics.com>
---
 board/esd/cpci750/cpci750.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Wolfgang Denk - Nov. 16, 2011, 8:05 p.m.
Dear Wolfgang Denk,

In message <1320866946-28235-12-git-send-email-wd@denx.de> you wrote:
> ThE code recorded error conditions but did not pass these on to the
> higher level caller.  Fixing this fixes also this build warning:
> cpci750.c: In function 'do_loadpci':
> cpci750.c:569:6: warning: variable 'status' set but not used
> [-Wunused-but-set-variable]
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Reinhard Arlt <reinhard.arlt@esd-electronics.com>
> ---
>  board/esd/cpci750/cpci750.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/board/esd/cpci750/cpci750.c b/board/esd/cpci750/cpci750.c
index f27d65e..08311c9 100644
--- a/board/esd/cpci750/cpci750.c
+++ b/board/esd/cpci750/cpci750.c
@@ -566,7 +566,7 @@  int do_loadpci(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	volatile unsigned int *ptr;
 	int count = 0;
 	int count2 = 0;
-	int status;
+	int status = 0;
 	char addr[16];
 	char str[] = "\\|/-";
 	char *local_args[2];
@@ -622,7 +622,7 @@  int do_loadpci(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 		break;
 	}
 
-	return 0;
+	return status;
 }
 
 U_BOOT_CMD(