Patchwork [2/2] target-arm: remind to keep arm features in sync with linux-user/elfload.c

login
register
mail settings
Submitter Benoit Canet
Date Nov. 9, 2011, 5:32 p.m.
Message ID <1320859979-10766-3-git-send-email-benoit.canet@gmail.com>
Download mbox | patch
Permalink /patch/124634/
State New
Headers show

Comments

Benoit Canet - Nov. 9, 2011, 5:32 p.m.
Signed-off-by: Benoit Canet <benoit.canet@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-arm/cpu.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Peter Maydell - April 11, 2012, 3 p.m.
2011/11/9 Benoît Canet <benoit.canet@gmail.com>:
> Signed-off-by: Benoit Canet <benoit.canet@gmail.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  target-arm/cpu.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)

I've put this in target-arm.next now that the linux-user
half of the patch has gone into master.

-- PMM

> diff --git a/target-arm/cpu.h b/target-arm/cpu.h
> index c4d742f..6639c2e 100644
> --- a/target-arm/cpu.h
> +++ b/target-arm/cpu.h
> @@ -353,6 +353,10 @@ enum arm_cpu_mode {
>  #define ARM_IWMMXT_wCGR2       10
>  #define ARM_IWMMXT_wCGR3       11
>
> +/* If adding a feature bit which corresponds to a Linux ELF
> + * HWCAP bit, remember to update the feature-bit-to-hwcap
> + * mapping in linux-user/elfload.c:get_elf_hwcap().
> + */
>  enum arm_features {
>     ARM_FEATURE_VFP,
>     ARM_FEATURE_AUXCR,  /* ARM1026 Auxiliary control register.  */
> --
> 1.7.5.4
>

Patch

diff --git a/target-arm/cpu.h b/target-arm/cpu.h
index c4d742f..6639c2e 100644
--- a/target-arm/cpu.h
+++ b/target-arm/cpu.h
@@ -353,6 +353,10 @@  enum arm_cpu_mode {
 #define ARM_IWMMXT_wCGR2	10
 #define ARM_IWMMXT_wCGR3	11
 
+/* If adding a feature bit which corresponds to a Linux ELF
+ * HWCAP bit, remember to update the feature-bit-to-hwcap
+ * mapping in linux-user/elfload.c:get_elf_hwcap().
+ */
 enum arm_features {
     ARM_FEATURE_VFP,
     ARM_FEATURE_AUXCR,  /* ARM1026 Auxiliary control register.  */