diff mbox series

spl.h: make <spl.h> self-contained

Message ID 20200224172547.14072-1-masahiroy@kernel.org
State Accepted
Commit 271cf2f421af072932404d56e6a7c97538d65de0
Delegated to: Tom Rini
Headers show
Series spl.h: make <spl.h> self-contained | expand

Commit Message

Masahiro Yamada Feb. 24, 2020, 5:25 p.m. UTC
The static inline function spl_phase needs <asm/global_data.h>.

Some functions take pointers to struct blk_desc or image_header.
Add forward declarations.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 include/spl.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Simon Glass Feb. 26, 2020, 3:33 p.m. UTC | #1
On Mon, 24 Feb 2020 at 10:26, Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> The static inline function spl_phase needs <asm/global_data.h>.
>
> Some functions take pointers to struct blk_desc or image_header.
> Add forward declarations.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
>  include/spl.h | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini March 17, 2020, 3:28 p.m. UTC | #2
On Tue, Feb 25, 2020 at 02:25:46AM +0900, Masahiro Yamada wrote:

> The static inline function spl_phase needs <asm/global_data.h>.
> 
> Some functions take pointers to struct blk_desc or image_header.
> Add forward declarations.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/include/spl.h b/include/spl.h
index 6087cd793c..5d8d14dbf5 100644
--- a/include/spl.h
+++ b/include/spl.h
@@ -10,9 +10,13 @@ 
 
 /* Platform-specific defines */
 #include <linux/compiler.h>
+#include <asm/global_data.h>
 #include <asm/spl.h>
 #include <handoff.h>
 
+struct blk_desc;
+struct image_header;
+
 /* Value in r0 indicates we booted from U-Boot */
 #define UBOOT_NOT_LOADED_FROM_SPL	0x13578642