| Message ID | 20200217132922.24607-1-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] hw/misc/iotkit-secctl: Fix writing to 'PPC Interrupt Clear' register | expand |
On Mon, 17 Feb 2020 at 13:29, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > Fix warning reported by Clang static code analyzer: > > CC hw/misc/iotkit-secctl.o > hw/misc/iotkit-secctl.c:343:9: warning: Value stored to 'value' is never read > value &= 0x00f000f3; > ^ ~~~~~~~~~~ > > Fixes: b3717c23e1c > Reported-by: Clang Static Analyzer > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > v3: AND the register... (pm215) > v2: Corrected bitwise-not precedence (pm215) > --- > hw/misc/iotkit-secctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to target-arm.next, thanks. -- PMM
diff --git a/hw/misc/iotkit-secctl.c b/hw/misc/iotkit-secctl.c index 609869821a..9fdb82056a 100644 --- a/hw/misc/iotkit-secctl.c +++ b/hw/misc/iotkit-secctl.c @@ -340,7 +340,7 @@ static MemTxResult iotkit_secctl_s_write(void *opaque, hwaddr addr, qemu_set_irq(s->sec_resp_cfg, s->secrespcfg); break; case A_SECPPCINTCLR: - value &= 0x00f000f3; + s->secppcintstat &= ~(value & 0x00f000f3); foreach_ppc(s, iotkit_secctl_ppc_update_irq_clear); break; case A_SECPPCINTEN:
Fix warning reported by Clang static code analyzer: CC hw/misc/iotkit-secctl.o hw/misc/iotkit-secctl.c:343:9: warning: Value stored to 'value' is never read value &= 0x00f000f3; ^ ~~~~~~~~~~ Fixes: b3717c23e1c Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- v3: AND the register... (pm215) v2: Corrected bitwise-not precedence (pm215) --- hw/misc/iotkit-secctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)