| Message ID | 20200215204604.21926-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | 67817b3b7a885b86b02b222675e0e29b1a2f25bf |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | [1/1] dm: core: remove redundant assignment | expand |
On Sat, 15 Feb 2020 at 13:46, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > Variable count is initialized at the start of every round of the while > loop and it is not used after the while loop. So there is no need to > initialize it beforehand. > > Identified by cppcheck. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > drivers/core/of_access.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass <sjg@chromium.org>
On Sat, 15 Feb 2020 at 13:46, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > Variable count is initialized at the start of every round of the while > loop and it is not used after the while loop. So there is no need to > initialize it beforehand. > > Identified by cppcheck. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > drivers/core/of_access.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot-dm, thanks!
diff --git a/drivers/core/of_access.c b/drivers/core/of_access.c index acd745c121..29e705e0b6 100644 --- a/drivers/core/of_access.c +++ b/drivers/core/of_access.c @@ -577,7 +577,7 @@ static int __of_parse_phandle_with_args(const struct device_node *np, { const __be32 *list, *list_end; int rc = 0, cur_index = 0; - uint32_t count = 0; + uint32_t count; struct device_node *node = NULL; phandle phandle; int size;
Variable count is initialized at the start of every round of the while loop and it is not used after the while loop. So there is no need to initialize it beforehand. Identified by cppcheck. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- drivers/core/of_access.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.0