| Message ID | 20200128220528.8249-1-jorge@foundries.io |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | configs: db820c: set bootm_size | expand |
On Tue, Jan 28, 2020 at 11:05:28PM +0100, Jorge Ramirez-Ortiz wrote: > set bootm_size to the memory available to safely contain a kernel, > device tree and initrd for relocation. > > Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io> > --- > include/configs/dragonboard820c.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/configs/dragonboard820c.h b/include/configs/dragonboard820c.h > index 4256e6f060..d7bfb7a100 100644 > --- a/include/configs/dragonboard820c.h > +++ b/include/configs/dragonboard820c.h > @@ -48,6 +48,7 @@ > "ramdisk_addr_r=0x91000000\0"\ > "scriptaddr=0x90000000\0"\ > "pxefile_addr_r=0x90100000\0"\ > + "bootm_size=0x8000000"\ > BOOTENV > > /* Size of malloc() pool */ We need to also remove fdt_high while we do this. And per the email I sent out today it would be good to audit the rest of the variables wrt booti (in this case) usage. It would be good to confirm we don't want to have initrd relocation. In the case of this platform, I would strongly encourage that as it places the initrd below the fdt and kernel and there is a long history of reports of problems later on with large initrds stomping over things, or being stomped over (load initrd, load fdt, load kernel, raw initrd support so kernel fails to find valid initrd is the failure). Thanks!
diff --git a/include/configs/dragonboard820c.h b/include/configs/dragonboard820c.h index 4256e6f060..d7bfb7a100 100644 --- a/include/configs/dragonboard820c.h +++ b/include/configs/dragonboard820c.h @@ -48,6 +48,7 @@ "ramdisk_addr_r=0x91000000\0"\ "scriptaddr=0x90000000\0"\ "pxefile_addr_r=0x90100000\0"\ + "bootm_size=0x8000000"\ BOOTENV /* Size of malloc() pool */
set bootm_size to the memory available to safely contain a kernel, device tree and initrd for relocation. Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io> --- include/configs/dragonboard820c.h | 1 + 1 file changed, 1 insertion(+)