| Message ID | 20200124123346.32210-2-patrick.delaunay@st.com |
|---|---|
| State | Superseded |
| Delegated to: | Joe Hershberger |
| Headers | show |
| Series | [1/5] cmd: env: add option for quiet output on env info | expand |
On Fri, 24 Jan 2020 at 05:34, Patrick Delaunay <patrick.delaunay@st.com> wrote: > > Use the define ENV_IS_IN_DEVICE to test if one the > CONFIG_ENV_IS_IN_... is defined and correct the detection of > persistent storage support in the command "env info" > if CONFIG_ENV_IS_NOWHERE is activated. > > Since commit 60d5ed2593c9 ("env: allow ENV_IS_NOWHERE with > other storage target") test CONFIG_ENV_IS_NOWHERE is not > enough; see also commit 953db29a1e9c6 ("env: enable saveenv > command when one CONFIG_ENV_IS_IN is activated"). > > This patch avoids issue for this command in stm32mp1 platform. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > --- > > cmd/nvedit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> We should add more tests for the environment functionality.
Hi Simon, > From: Simon Glass <sjg@chromium.org> > Sent: jeudi 30 janvier 2020 03:18 > > On Fri, 24 Jan 2020 at 05:34, Patrick Delaunay <patrick.delaunay@st.com> > wrote: > > > > Use the define ENV_IS_IN_DEVICE to test if one the > > CONFIG_ENV_IS_IN_... is defined and correct the detection of > > persistent storage support in the command "env info" > > if CONFIG_ENV_IS_NOWHERE is activated. > > > > Since commit 60d5ed2593c9 ("env: allow ENV_IS_NOWHERE with other > > storage target") test CONFIG_ENV_IS_NOWHERE is not enough; see also > > commit 953db29a1e9c6 ("env: enable saveenv command when one > > CONFIG_ENV_IS_IN is activated"). > > > > This patch avoids issue for this command in stm32mp1 platform. > > > > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > > --- > > > > cmd/nvedit.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> > > We should add more tests for the environment functionality. Sorry for the delay, I need to activate a location in sandbox to test this feature.... I am working on a other serie for it (I am trying to add test for env in EXT4). Patrick
diff --git a/cmd/nvedit.c b/cmd/nvedit.c index aaa032cd96..3d1054e763 100644 --- a/cmd/nvedit.c +++ b/cmd/nvedit.c @@ -1268,7 +1268,7 @@ static int do_env_info(cmd_tbl_t *cmdtp, int flag, /* evaluate whether environment can be persisted */ if (eval_flags & ENV_INFO_IS_PERSISTED) { -#if defined(CONFIG_CMD_SAVEENV) && !defined(CONFIG_ENV_IS_NOWHERE) +#if defined(CONFIG_CMD_SAVEENV) && defined(ENV_IS_IN_DEVICE) if (!quiet) printf("Environment can be persisted\n"); eval_results |= ENV_INFO_IS_PERSISTED;
Use the define ENV_IS_IN_DEVICE to test if one the CONFIG_ENV_IS_IN_... is defined and correct the detection of persistent storage support in the command "env info" if CONFIG_ENV_IS_NOWHERE is activated. Since commit 60d5ed2593c9 ("env: allow ENV_IS_NOWHERE with other storage target") test CONFIG_ENV_IS_NOWHERE is not enough; see also commit 953db29a1e9c6 ("env: enable saveenv command when one CONFIG_ENV_IS_IN is activated"). This patch avoids issue for this command in stm32mp1 platform. Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> --- cmd/nvedit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)