| Message ID | 20200113225932.28031-1-arnout@mind.be |
|---|---|
| State | Accepted |
| Headers | show |
| Series | toolchain/toolchain-external: warn for untested GCC/kernel version | expand |
Arnout, All, On 2020-01-13 23:59 +0100, Arnout Vandecappelle (Essensium/Mind) spake thusly: > The oldest toolchain we test in the autobuilders is the Sourcery ARM > toolchain which is GCC 4.8 and kernel headers 3.13. Therefore, it is > likely that we're missing the required _AT_LEAST dependencies to exclude > packages that don't build with older GCC/headers. > > Add a comment to the custom external toolchain that warns when an > untested GCC or kernel headers version is selected. > > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Applied to master, thanks. Regards, Yann E. MORIN. > --- > This patch was triggered by [1], where I observed that zxing-cpp is > probably missing a GCC_AT_LEAST_4_8 dependency, but we don't detect this > in the autobuilders for lack of an older toolchain. > > Note that this also means we should probably remove all older > GCC_AT_LEAST options from packages. > > Alternatively, we could in the custom external toolchain remove all the > old options (and also remove them from packages), and replace it with > e.g. "4.8 or earlier". > > But for the time being, this patch is simpler :-) > > [1] http://lists.busybox.net/pipermail/buildroot/2020-January/271558.html > --- > .../toolchain-external-custom/Config.in.options | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options > index 665765a104..9680509a13 100644 > --- a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options > +++ b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options > @@ -92,6 +92,9 @@ config BR2_TOOLCHAIN_EXTERNAL_GCC_OLD > > endchoice > > +comment "GCC older than 4.8 is not tested by Buildroot. Use at your own risk." > + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 > + > choice > bool "External toolchain kernel headers series" > default BR2_TOOLCHAIN_EXTERNAL_HEADERS_REALLY_OLD > @@ -298,6 +301,9 @@ config BR2_TOOLCHAIN_EXTERNAL_HEADERS_REALLY_OLD > > endchoice > > +comment "Kernel headers older than 3.13 is not tested by Buildroot. Use at your own risk." > + depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_13 > + > choice > prompt "External toolchain C library" > default BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC > -- > 2.21.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
diff --git a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options index 665765a104..9680509a13 100644 --- a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options +++ b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options @@ -92,6 +92,9 @@ config BR2_TOOLCHAIN_EXTERNAL_GCC_OLD endchoice +comment "GCC older than 4.8 is not tested by Buildroot. Use at your own risk." + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 + choice bool "External toolchain kernel headers series" default BR2_TOOLCHAIN_EXTERNAL_HEADERS_REALLY_OLD @@ -298,6 +301,9 @@ config BR2_TOOLCHAIN_EXTERNAL_HEADERS_REALLY_OLD endchoice +comment "Kernel headers older than 3.13 is not tested by Buildroot. Use at your own risk." + depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_13 + choice prompt "External toolchain C library" default BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC
The oldest toolchain we test in the autobuilders is the Sourcery ARM toolchain which is GCC 4.8 and kernel headers 3.13. Therefore, it is likely that we're missing the required _AT_LEAST dependencies to exclude packages that don't build with older GCC/headers. Add a comment to the custom external toolchain that warns when an untested GCC or kernel headers version is selected. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> --- This patch was triggered by [1], where I observed that zxing-cpp is probably missing a GCC_AT_LEAST_4_8 dependency, but we don't detect this in the autobuilders for lack of an older toolchain. Note that this also means we should probably remove all older GCC_AT_LEAST options from packages. Alternatively, we could in the custom external toolchain remove all the old options (and also remove them from packages), and replace it with e.g. "4.8 or earlier". But for the time being, this patch is simpler :-) [1] http://lists.busybox.net/pipermail/buildroot/2020-January/271558.html --- .../toolchain-external-custom/Config.in.options | 6 ++++++ 1 file changed, 6 insertions(+)