diff mbox series

imx8m: ddr_init: Move ddr_init() messages to debug level

Message ID 20191211203709.26478-1-festevam@gmail.com
State Accepted
Commit 0d3bc81391ac031758affdb0811bc9c8b905978c
Delegated to: Stefano Babic
Headers show
Series imx8m: ddr_init: Move ddr_init() messages to debug level | expand

Commit Message

Fabio Estevam Dec. 11, 2019, 8:37 p.m. UTC
Currently inside ddr_init() there is a mix of printf() and debug()
level messages.

Since this type of information is useful for debug purposes,
convert all of them to debug level for consistency.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 drivers/ddr/imx/imx8m/ddr_init.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Peng Fan Dec. 12, 2019, 1:21 a.m. UTC | #1
> Subject: [PATCH] imx8m: ddr_init: Move ddr_init() messages to debug level
> 
> Currently inside ddr_init() there is a mix of printf() and debug() level messages.
> 
> Since this type of information is useful for debug purposes, convert all of them
> to debug level for consistency.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  drivers/ddr/imx/imx8m/ddr_init.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/ddr/imx/imx8m/ddr_init.c
> b/drivers/ddr/imx/imx8m/ddr_init.c
> index d6e915c9b9..21af66e4e7 100644
> --- a/drivers/ddr/imx/imx8m/ddr_init.c
> +++ b/drivers/ddr/imx/imx8m/ddr_init.c
> @@ -24,7 +24,7 @@ void ddr_init(struct dram_timing_info *dram_timing)  {
>  	unsigned int tmp, initial_drate, target_freq;
> 
> -	printf("DDRINFO: start DRAM init\n");
> +	debug("DDRINFO: start DRAM init\n");
> 
>  	/* Step1: Follow the power up procedure */
>  	if (is_imx8mq()) {
> @@ -109,7 +109,7 @@ void ddr_init(struct dram_timing_info *dram_timing)
>  		tmp = reg32_read(DDRPHY_CalBusy(0));
>  	} while ((tmp & 0x1));
> 
> -	printf("DDRINFO:ddrphy calibration done\n");
> +	debug("DDRINFO:ddrphy calibration done\n");
> 
>  	/* Step15: Set SWCTL.sw_done to 0 */
>  	reg32_write(DDRC_SWCTL(0), 0x00000000); @@ -161,7 +161,7 @@
> void ddr_init(struct dram_timing_info *dram_timing)
> 
>  	/* enable port 0 */
>  	reg32_write(DDRC_PCTRL_0(0), 0x00000001);
> -	printf("DDRINFO: ddrmix config done\n");
> +	debug("DDRINFO: ddrmix config done\n");
> 
>  	/* save the dram timing config into memory */
>  	dram_config_save(dram_timing,
> CONFIG_SAVED_DRAM_TIMING_BASE);
> --
> 2.17.1
Stefano Babic Dec. 28, 2019, 10:48 a.m. UTC | #2
> Currently inside ddr_init() there is a mix of printf() and debug()
> level messages.
> Since this type of information is useful for debug purposes,
> convert all of them to debug level for consistency.
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/drivers/ddr/imx/imx8m/ddr_init.c b/drivers/ddr/imx/imx8m/ddr_init.c
index d6e915c9b9..21af66e4e7 100644
--- a/drivers/ddr/imx/imx8m/ddr_init.c
+++ b/drivers/ddr/imx/imx8m/ddr_init.c
@@ -24,7 +24,7 @@  void ddr_init(struct dram_timing_info *dram_timing)
 {
 	unsigned int tmp, initial_drate, target_freq;
 
-	printf("DDRINFO: start DRAM init\n");
+	debug("DDRINFO: start DRAM init\n");
 
 	/* Step1: Follow the power up procedure */
 	if (is_imx8mq()) {
@@ -109,7 +109,7 @@  void ddr_init(struct dram_timing_info *dram_timing)
 		tmp = reg32_read(DDRPHY_CalBusy(0));
 	} while ((tmp & 0x1));
 
-	printf("DDRINFO:ddrphy calibration done\n");
+	debug("DDRINFO:ddrphy calibration done\n");
 
 	/* Step15: Set SWCTL.sw_done to 0 */
 	reg32_write(DDRC_SWCTL(0), 0x00000000);
@@ -161,7 +161,7 @@  void ddr_init(struct dram_timing_info *dram_timing)
 
 	/* enable port 0 */
 	reg32_write(DDRC_PCTRL_0(0), 0x00000001);
-	printf("DDRINFO: ddrmix config done\n");
+	debug("DDRINFO: ddrmix config done\n");
 
 	/* save the dram timing config into memory */
 	dram_config_save(dram_timing, CONFIG_SAVED_DRAM_TIMING_BASE);