| Message ID | 20191211192742.95699-3-brendanhiggins@google.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | uml: add unspecified HAS_IOMEM dependencies | expand |
Hi Brendan, Brendan Higgins <brendanhiggins@google.com> wrote on Wed, 11 Dec 2019 11:27:37 -0800: > Currently CONFIG_MTD_NAND_CADENCE implicitly depends on > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > the following build error: > > ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31': > drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource' > ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource' > > Fix the build error by adding the unspecified dependency. > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > --- Sorry for the delay. Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl
On Thu, Jan 9, 2020 at 7:23 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > Hi Brendan, > > Brendan Higgins <brendanhiggins@google.com> wrote on Wed, 11 Dec 2019 > 11:27:37 -0800: > > > Currently CONFIG_MTD_NAND_CADENCE implicitly depends on > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > > the following build error: > > > > ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31': > > drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource' > > ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource' > > > > Fix the build error by adding the unspecified dependency. > > > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > --- > > Sorry for the delay. > > Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> It looks like my change has not been applied to nand/next; is this the branch it should be applied to? I have also verified that this patch isn't in linux-next as of Jan 24th. Is mtd/linux the correct tree for this? Or do I need to reach out to someone else? Cheers
Hi Brendan, Brendan Higgins <brendanhiggins@google.com> wrote on Fri, 24 Jan 2020 18:12:12 -0800: > On Thu, Jan 9, 2020 at 7:23 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > > > Hi Brendan, > > > > Brendan Higgins <brendanhiggins@google.com> wrote on Wed, 11 Dec 2019 > > 11:27:37 -0800: > > > > > Currently CONFIG_MTD_NAND_CADENCE implicitly depends on > > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > > > the following build error: > > > > > > ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31': > > > drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource' > > > ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource' > > > > > > Fix the build error by adding the unspecified dependency. > > > > > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > > --- > > > > Sorry for the delay. > > > > Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> > > It looks like my change has not been applied to nand/next; is this the > branch it should be applied to? I have also verified that this patch > isn't in linux-next as of Jan 24th. > > Is mtd/linux the correct tree for this? Or do I need to reach out to > someone else? When I sent my Acked-by I supposed someone else would pick the patch, but there is actually no dependency with all the other patches so I don't know why I did it... Sorry about that. I'll take it anyway in my PR for 5.6. Thanks, Miquèl
On Sat, Jan 25, 2020 at 7:28 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > Hi Brendan, > > Brendan Higgins <brendanhiggins@google.com> wrote on Fri, 24 Jan 2020 > 18:12:12 -0800: > > > On Thu, Jan 9, 2020 at 7:23 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > > > > > Hi Brendan, > > > > > > Brendan Higgins <brendanhiggins@google.com> wrote on Wed, 11 Dec 2019 > > > 11:27:37 -0800: > > > > > > > Currently CONFIG_MTD_NAND_CADENCE implicitly depends on > > > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > > > > the following build error: > > > > > > > > ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31': > > > > drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource' > > > > ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource' > > > > > > > > Fix the build error by adding the unspecified dependency. > > > > > > > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > > > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > > > --- > > > > > > Sorry for the delay. > > > > > > Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> > > > > It looks like my change has not been applied to nand/next; is this the > > branch it should be applied to? I have also verified that this patch > > isn't in linux-next as of Jan 24th. > > > > Is mtd/linux the correct tree for this? Or do I need to reach out to > > someone else? > > When I sent my Acked-by I supposed someone else would pick the patch, > but there is actually no dependency with all the other patches so I > don't know why I did it... Sorry about that. I'll take it anyway in my > PR for 5.6. No worries, thanks!
Hello, Miquel Raynal <miquel.raynal@bootlin.com> wrote on Sat, 25 Jan 2020 16:28:03 +0100: > Hi Brendan, > > Brendan Higgins <brendanhiggins@google.com> wrote on Fri, 24 Jan 2020 > 18:12:12 -0800: > > > On Thu, Jan 9, 2020 at 7:23 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > > > > > Hi Brendan, > > > > > > Brendan Higgins <brendanhiggins@google.com> wrote on Wed, 11 Dec 2019 > > > 11:27:37 -0800: > > > > > > > Currently CONFIG_MTD_NAND_CADENCE implicitly depends on > > > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > > > > the following build error: > > > > > > > > ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31': > > > > drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource' > > > > ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource' > > > > > > > > Fix the build error by adding the unspecified dependency. > > > > > > > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > > > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > > > --- > > > > > > Sorry for the delay. > > > > > > Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> > > > > It looks like my change has not been applied to nand/next; is this the > > branch it should be applied to? I have also verified that this patch > > isn't in linux-next as of Jan 24th. > > > > Is mtd/linux the correct tree for this? Or do I need to reach out to > > someone else? > > When I sent my Acked-by I supposed someone else would pick the patch, > but there is actually no dependency with all the other patches so I > don't know why I did it... Sorry about that. I'll take it anyway in my > PR for 5.6. It is applied on top of mtd/next since a few days, it will be part of the 5.6 PR. Sorry for the delay. Thanks, Miquèl
On Thu, Jan 30, 2020 at 11:50 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > Hello, > > Miquel Raynal <miquel.raynal@bootlin.com> wrote on Sat, 25 Jan 2020 > 16:28:03 +0100: > > > Hi Brendan, > > > > Brendan Higgins <brendanhiggins@google.com> wrote on Fri, 24 Jan 2020 > > 18:12:12 -0800: > > > > > On Thu, Jan 9, 2020 at 7:23 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > > > > > > > Hi Brendan, > > > > > > > > Brendan Higgins <brendanhiggins@google.com> wrote on Wed, 11 Dec 2019 > > > > 11:27:37 -0800: > > > > > > > > > Currently CONFIG_MTD_NAND_CADENCE implicitly depends on > > > > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > > > > > the following build error: > > > > > > > > > > ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31': > > > > > drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource' > > > > > ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource' > > > > > > > > > > Fix the build error by adding the unspecified dependency. > > > > > > > > > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > > > > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > > > > --- > > > > > > > > Sorry for the delay. > > > > > > > > Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> > > > > > > It looks like my change has not been applied to nand/next; is this the > > > branch it should be applied to? I have also verified that this patch > > > isn't in linux-next as of Jan 24th. > > > > > > Is mtd/linux the correct tree for this? Or do I need to reach out to > > > someone else? > > > > When I sent my Acked-by I supposed someone else would pick the patch, > > but there is actually no dependency with all the other patches so I > > don't know why I did it... Sorry about that. I'll take it anyway in my > > PR for 5.6. > > It is applied on top of mtd/next since a few days, it will be part of > the 5.6 PR. > > Sorry for the delay. No worries. Thanks!
diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig index 74fb91adeb469..a80a46bb5b8bc 100644 --- a/drivers/mtd/nand/raw/Kconfig +++ b/drivers/mtd/nand/raw/Kconfig @@ -452,7 +452,7 @@ config MTD_NAND_PLATFORM config MTD_NAND_CADENCE tristate "Support Cadence NAND (HPNFC) controller" - depends on OF || COMPILE_TEST + depends on (OF || COMPILE_TEST) && HAS_IOMEM help Enable the driver for NAND flash on platforms using a Cadence NAND controller.
Currently CONFIG_MTD_NAND_CADENCE implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error: ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31': drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource' ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource' Fix the build error by adding the unspecified dependency. Reported-by: Brendan Higgins <brendanhiggins@google.com> Signed-off-by: Brendan Higgins <brendanhiggins@google.com> --- drivers/mtd/nand/raw/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)