| Message ID | 20191211192742.95699-7-brendanhiggins@google.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | uml: add unspecified HAS_IOMEM dependencies | expand |
On Wed, Dec 11, 2019 at 11:27:41AM -0800, Brendan Higgins wrote: > Currently CONFIG_XIL_AXIS_FIFO=y implicitly depends on > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > the following build error: > > ld: drivers/staging/axis-fifo/axis-fifo.o: in function `axis_fifo_probe': > drivers/staging/axis-fifo/axis-fifo.c:809: undefined reference to `devm_ioremap_resource' > > Fix the build error by adding the unspecified dependency. > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> Saying you reported a problem and then fixed it kind of does a bit of disservice to the "reported-by:" tag which we normally use only to credit the people that do not actually fix the problem. So in the future, no need for this to be there for patches that you write yourself. thanks, greg k-h
On Sat, Dec 14, 2019 at 3:28 AM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Wed, Dec 11, 2019 at 11:27:41AM -0800, Brendan Higgins wrote: > > Currently CONFIG_XIL_AXIS_FIFO=y implicitly depends on > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > > the following build error: > > > > ld: drivers/staging/axis-fifo/axis-fifo.o: in function `axis_fifo_probe': > > drivers/staging/axis-fifo/axis-fifo.c:809: undefined reference to `devm_ioremap_resource' > > > > Fix the build error by adding the unspecified dependency. > > > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > Saying you reported a problem and then fixed it kind of does a bit of > disservice to the "reported-by:" tag which we normally use only to > credit the people that do not actually fix the problem. > > So in the future, no need for this to be there for patches that you > write yourself. Alright, thanks for spelling that out. I will remember that in the future. Cheers!
diff --git a/drivers/staging/axis-fifo/Kconfig b/drivers/staging/axis-fifo/Kconfig index 3fffe4d6f327f..f180a8e9f58af 100644 --- a/drivers/staging/axis-fifo/Kconfig +++ b/drivers/staging/axis-fifo/Kconfig @@ -4,7 +4,7 @@ # config XIL_AXIS_FIFO tristate "Xilinx AXI-Stream FIFO IP core driver" - depends on OF + depends on OF && HAS_IOMEM help This adds support for the Xilinx AXI-Stream FIFO IP core driver. The AXI Streaming FIFO allows memory mapped access to a AXI Streaming
Currently CONFIG_XIL_AXIS_FIFO=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error: ld: drivers/staging/axis-fifo/axis-fifo.o: in function `axis_fifo_probe': drivers/staging/axis-fifo/axis-fifo.c:809: undefined reference to `devm_ioremap_resource' Fix the build error by adding the unspecified dependency. Reported-by: Brendan Higgins <brendanhiggins@google.com> Signed-off-by: Brendan Higgins <brendanhiggins@google.com> --- drivers/staging/axis-fifo/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)