| Message ID | 20191210064333.2769-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted, archived |
| Commit | c013a2f7856eab890d17cf4aee1042e768218bc3 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [1/1] common: remove duplicate typedef for uchar | expand |
Hi Heinrich, On Tue, Dec 10, 2019 at 12:44 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > With commit 37db55b7e9db ("linux/types.h: fix typo unchar") we have a > duplicate typedef for uchar. As linux/types.h is included in common.h we > don't need another typedef for uchar there. > > Fixes: 37db55b7e9db ("linux/types.h: fix typo unchar") > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
On Tue, Dec 10, 2019 at 07:43:33AM +0100, Heinrich Schuchardt wrote: > With commit 37db55b7e9db ("linux/types.h: fix typo unchar") we have a > duplicate typedef for uchar. As linux/types.h is included in common.h we > don't need another typedef for uchar there. > > Fixes: 37db55b7e9db ("linux/types.h: fix typo unchar") > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > Reviewed-by: Joe Hershberger <joe.hershberger@ni.com> Applied to u-boot/master, thanks!
diff --git a/include/common.h b/include/common.h index 8b37b58747..52c02185f4 100644 --- a/include/common.h +++ b/include/common.h @@ -15,7 +15,6 @@ #ifndef __ASSEMBLY__ /* put C only stuff in this section */ -typedef unsigned char uchar; typedef volatile unsigned long vu_long; typedef volatile unsigned short vu_short; typedef volatile unsigned char vu_char;
With commit 37db55b7e9db ("linux/types.h: fix typo unchar") we have a duplicate typedef for uchar. As linux/types.h is included in common.h we don't need another typedef for uchar there. Fixes: 37db55b7e9db ("linux/types.h: fix typo unchar") Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- include/common.h | 1 - 1 file changed, 1 deletion(-) -- 2.24.0