| Message ID | 71997c6978551392c4838391dff019ced8e2c012.1575903534.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Commit | b4f8468187e7bc702a0e38815684e84f8a258812 |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | arm64: zynqmp: Fix return value of board_fit_config_name_match | expand |
po 9. 12. 2019 v 15:58 odesÃlatel Michal Simek <michal.simek@xilinx.com> napsal: > > Empty implementation should not return 0 (success) because that mean that > passed name matches the board configuration. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > arch/arm/mach-zynqmp/spl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-zynqmp/spl.c b/arch/arm/mach-zynqmp/spl.c > index 37f690d9b958..76bafcdd2a38 100644 > --- a/arch/arm/mach-zynqmp/spl.c > +++ b/arch/arm/mach-zynqmp/spl.c > @@ -139,6 +139,6 @@ int board_fit_config_name_match(const char *name) > /* Just empty function now - can't decide what to choose */ > debug("%s: %s\n", __func__, name); > > - return 0; > + return -1; > } > #endif > -- > 2.24.0 > Applied. M
diff --git a/arch/arm/mach-zynqmp/spl.c b/arch/arm/mach-zynqmp/spl.c index 37f690d9b958..76bafcdd2a38 100644 --- a/arch/arm/mach-zynqmp/spl.c +++ b/arch/arm/mach-zynqmp/spl.c @@ -139,6 +139,6 @@ int board_fit_config_name_match(const char *name) /* Just empty function now - can't decide what to choose */ debug("%s: %s\n", __func__, name); - return 0; + return -1; } #endif
Empty implementation should not return 0 (success) because that mean that passed name matches the board configuration. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- arch/arm/mach-zynqmp/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)