diff mbox series

[OpenWrt-Devel,2/2] ustream-ssl: mbedtls: fix ssl client verification

Message ID 20191208161419.124991-2-daniel@dd-wrt.com
State Changes Requested
Headers show
Series [OpenWrt-Devel,1/2] ustream-ssl: mbedtls: fix net_sockets.h include warning | expand

Commit Message

Daniel Danzberger Dec. 8, 2019, 4:14 p.m. UTC
Signed-off-by: Daniel Danzberger <daniel@dd-wrt.com>
---
 ustream-mbedtls.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Daniel Golle Dec. 8, 2019, 7:14 p.m. UTC | #1
Hi Daniel,

On Sun, Dec 08, 2019 at 05:14:19PM +0100, Daniel Danzberger wrote:
> Signed-off-by: Daniel Danzberger <daniel@dd-wrt.com>
> ---
>  ustream-mbedtls.c | 7 -------
>  1 file changed, 7 deletions(-)

Please provide a more elaborate commit description as it is not obvious
why those lines need to be removed.

> 
> diff --git a/ustream-mbedtls.c b/ustream-mbedtls.c
> index 85bbb1c..74c27a5 100644
> --- a/ustream-mbedtls.c
> +++ b/ustream-mbedtls.c
> @@ -182,16 +182,9 @@ static void ustream_ssl_update_own_cert(struct ustream_ssl_ctx *ctx)
>  	if (!ctx->cert.version)
>  		return;
>  
> -	if (!ctx->server) {
> -		mbedtls_ssl_conf_ca_chain(&ctx->conf, &ctx->cert, NULL);
> -		return;
> -	}
> -
>  	if (!ctx->key.pk_info)
>  		return;
>  
> -	if (ctx->cert.next)
> -		mbedtls_ssl_conf_ca_chain(&ctx->conf, ctx->cert.next, NULL);
>  	mbedtls_ssl_conf_own_cert(&ctx->conf, &ctx->cert, &ctx->key);
>  }
>  
> -- 
> 2.24.0
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff mbox series

Patch

diff --git a/ustream-mbedtls.c b/ustream-mbedtls.c
index 85bbb1c..74c27a5 100644
--- a/ustream-mbedtls.c
+++ b/ustream-mbedtls.c
@@ -182,16 +182,9 @@  static void ustream_ssl_update_own_cert(struct ustream_ssl_ctx *ctx)
 	if (!ctx->cert.version)
 		return;
 
-	if (!ctx->server) {
-		mbedtls_ssl_conf_ca_chain(&ctx->conf, &ctx->cert, NULL);
-		return;
-	}
-
 	if (!ctx->key.pk_info)
 		return;
 
-	if (ctx->cert.next)
-		mbedtls_ssl_conf_ca_chain(&ctx->conf, ctx->cert.next, NULL);
 	mbedtls_ssl_conf_own_cert(&ctx->conf, &ctx->cert, &ctx->key);
 }