| Message ID | 8c8ec4ace1add01c65a4d0e749cdec3661086a87.1573759321.git.yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/3] package/gettext-tiny: fix prefix in autopoint | expand |
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > When a textdomain is specified, we ignore it twice: we shift args, and > we printf ${2}, which would yield an empty printf. > Fix that by not shifting, and just printf ${2}; this is nicer. > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> > Cc: Vadim Kochan <vadim4j@gmail.com> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Committed to 2019.08.x (not in 2019.02.x), thanks.
diff --git a/package/gettext-tiny/gettext-wrapper b/package/gettext-tiny/gettext-wrapper index 3791a3a1aa..11424824c3 100644 --- a/package/gettext-tiny/gettext-wrapper +++ b/package/gettext-tiny/gettext-wrapper @@ -19,6 +19,6 @@ done case ${#} in (0) printf "missing arguments\n" >&2; return 1;; (1) printf "%s" "${1}";; - (2) shift; printf "%s" "${2}";; + (2) printf "%s" "${2}";; (*) printf "too many arguments\n" >&2; return 1;; esac
When a textdomain is specified, we ignore it twice: we shift args, and we printf ${2}, which would yield an empty printf. Fix that by not shifting, and just printf ${2}; this is nicer. Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> Cc: Vadim Kochan <vadim4j@gmail.com> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- package/gettext-tiny/gettext-wrapper | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)