Patchwork [U-Boot,2/3] ppc4xx: remove invalid access to PCI_BRDGOPT2 register

login
register
mail settings
Submitter Matthias Fuchs
Date Oct. 13, 2011, 1:12 p.m.
Message ID <13185115441965-git-send-email-matthias.fuchs@esd.eu>
Download mbox | patch
Permalink /patch/119495/
State Accepted
Commit baa3713fe258b7a970602438916fed9b5b267f82
Delegated to: Stefan Roese
Headers show

Comments

Matthias Fuchs - Oct. 13, 2011, 1:12 p.m.
From: Matthias Fuchs <matthias.fuchs@esd.eu>

This patch removes an invalid call to pci_write_config_dword to
PCI_BRDGOPT2 register. This function must not be used from pci_target_init
and is also at the wrong place. The correct call is done later in
pci_target_init via pci_hose_write_config_dword.

Signed-off-by: Matthias Fuchs <matthias.fuchs@esd.eu>
---
 board/esd/pmc440/pmc440.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Stefan Roese - Dec. 1, 2011, 8:12 a.m.
On Thursday 13 October 2011 15:12:23 matthias.fuchs@esd.eu wrote:
> From: Matthias Fuchs <matthias.fuchs@esd.eu>
> 
> This patch removes an invalid call to pci_write_config_dword to
> PCI_BRDGOPT2 register. This function must not be used from pci_target_init
> and is also at the wrong place. The correct call is done later in
> pci_target_init via pci_hose_write_config_dword.

Applied to u-boot-ppc4xx. Thanks.
 
Best regards,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de

Patch

diff --git a/board/esd/pmc440/pmc440.c b/board/esd/pmc440/pmc440.c
index 0d56064..3713e37 100644
--- a/board/esd/pmc440/pmc440.c
+++ b/board/esd/pmc440/pmc440.c
@@ -574,8 +574,6 @@  void pci_target_init(struct pci_controller *hose)
 	/* No error reporting */
 	pci_hose_write_config_word(hose, 0, PCI_ERREN, 0);
 
-	pci_write_config_dword(0, PCI_BRDGOPT2, 0x00000101);
-
 	if (!is_monarch()) {
 		/* Program the board's subsystem id/classcode */
 		pci_hose_write_config_word(hose, 0, PCI_SUBSYSTEM_ID,